Update output file name

[iamhopaul123]

Issue #, if available:
#796
Description of changes:

---

Enter [N/A] in the box, if an item is not applicable to your change.

Testing

• Unit tests passed
• Integration tests passed
• [N/A] Unit tests added for new functionality
• [N/A] Listed manual checks and their outputs in the comments (example)
• [N/A] Link to issue or PR for the integration tests:

Documentation

• [N/A] Contacted our doc writer
• [N/A] Updated our README

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[hencrice]

The original thread mentions that we have to update some code to use path.Join or os.PathSeparater. Are those changes done so that we can update project.go?

[iamhopaul123]

The original thread mentions that we have to update some code to use path.Join or os.PathSeparater. Are those changes done so that we can update project.go?

The reason for using filepath.Join is to get the pwd and concat with the file name so that we can get the valid file path for every os system. However, the test case just want to test the ability to create the yml file so I think we don't need to provide the full path.

[hencrice]

https://github.com/aws/amazon-ecs-cli/blob/ecs-local/ecs-cli/modules/cli/local/project/project.go This is not just a test, right?

[iamhopaul123]

https://github.com/aws/amazon-ecs-cli/blob/ecs-local/ecs-cli/modules/cli/local/project/project.go This is not just a test, right?

Well, I think I have to make some changes. Nice catch.

[iamhopaul123]

https://github.com/aws/amazon-ecs-cli/blob/ecs-local/ecs-cli/modules/cli/local/project/project.go This is not just a test, right?

Do the latest changes look good to you?

[efekarakus]

Can we leverage this variable in local ps or local down? https://github.com/aws/amazon-ecs-cli/blob/ecs-local/ecs-cli/modules/cli/local/ps_app.go#L89

Removing code duplication, the main concern is that for whatever reason if we rename docker-compose.local.yml to something else we will need to remember to update it in multiple locations instead of just here.

[iamhopaul123]

1. Yeah I agree with you. I think that is doable and will have a try.

2. "flags.LocalOutputFlag" is the string flag for customized yml name. If that flag is set, the default one will not be used. But I think we should get rid of "ecsLocalDockerComposeFileName" in create_app.go because this is not always the name we want.

[iamhopaul123]

Manual Tests

Run the "create" command

ecs-cli local create --arn arn:aws:ecs:us-west-2:403971813171:task-definition/e2e-ec2-tutorial- taskdef:1

Successfully wrote docker-compose.local.yml

After that, the yml file is created at the working directory without the path concern for different os systems.

[SoManyHs]

HI @iamhopaul123,

In the future, please provide a more descriptive, concise title to your PR and include the "Fixes <issue number" in the commit message. That will allow Github to close the related issue automatically.

We probably should have this codified in our own contributing doc, but in the meantime you can take a look at the description for how to title your PRs here as an example.

[iamhopaul123]

HI @iamhopaul123,

In the future, please provide a more descriptive, concise title to your PR and include the "Fixes <issue number" in the commit message. That will allow Github to close the related issue automatically.

We probably should have this codified in our own contributing doc, but in the meantime you can take a look at the description for how to title your PRs here as an example.

Hi @SoManyHs,

Thank you for your advice. I am sorry for this PR that might not be clear enough. And I will try to make the PR more descriptive in the future.