Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature for attaching multiple target groups in a service #1013

Merged
merged 12 commits into from Apr 28, 2020
Merged

Feature for attaching multiple target groups in a service #1013

merged 12 commits into from Apr 28, 2020

Conversation

seongm-1
Copy link
Contributor

@seongm-1 seongm-1 commented Apr 16, 2020 •
edited

The ability to register multiple target groups in a single service

Resolves #995

Enter [N/A] in the box, if an item is not applicable to your change.

Testing

  • Unit tests passed
  • Integration tests passed
  • Unit tests added for new functionality
  • Listed manual checks and their outputs in the comments (example)
  • Link to issue or PR for the integration tests:

Documentation

  • Contacted our doc writer
  • Updated our README

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@seongm-1 seongm-1 requested review from iamhopaul123, efekarakus and a team April 16, 2020 17:08
iamhopaul123
iamhopaul123 reviewed Apr 16, 2020
View reviewed changes
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrat for the first PR 🎊Thank you!

ecs-cli/modules/utils/utils.go Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Show resolved Hide resolved
@iamhopaul123
Copy link
Contributor

PS can you add unit test for this new change pls ❤️

iamhopaul123
iamhopaul123 reviewed Apr 21, 2020
View reviewed changes
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/utils/utils.go Outdated Show resolved Hide resolved
ecs-cli/modules/cli/compose/entity/service/service_test.go Show resolved Hide resolved
iamhopaul123
iamhopaul123 approved these changes Apr 23, 2020
View reviewed changes
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

iamhopaul123
iamhopaul123 approved these changes Apr 27, 2020
View reviewed changes
Copy link
Contributor

@iamhopaul123 iamhopaul123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing the manual test and diving deep!

@seongm-1 seongm-1 merged commit b4be656 into master Apr 28, 2020
@seongm-1 seongm-1 deleted the multiple-tg-service branch April 28, 2020 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvtujo bvtujo bvtujo left review comments

@efekarakus efekarakus efekarakus approved these changes

@iamhopaul123 iamhopaul123 iamhopaul123 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Support for Multiple Target Group
4 participants
@seongm-1 @iamhopaul123 @efekarakus @bvtujo