Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature for attaching multiple target groups in a service #1013

Merged
merged 12 commits into from
Apr 28, 2020
Merged

Feature for attaching multiple target groups in a service #1013

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
7c501b2
Feature for attaching multiple target groups in a service
seongm-1 Apr 16, 2020
89ececc
Changed flag name to target-groups, modified parsing loadbalancers
seongm-1 Apr 17, 2020
4a73056
Add multiple validators when registering a load balancers
seongm-1 Apr 17, 2020
a428f5a
Replaced loadBalancer from Service struct with loadBalancers
seongm-1 Apr 17, 2020
ab16687
Added an error when loadBalancerName and targetGroupArn are both pres…
seongm-1 Apr 17, 2020
60c4fee
Added unit tests
seongm-1 Apr 21, 2020
8eac125
Add more Unit Tests
seongm-1 Apr 21, 2020
0348ecb
Added currentFlags and invalidFlags for parsing load balancers
seongm-1 Apr 22, 2020
e963e7d
Added const vars for targetGroups params
seongm-1 Apr 22, 2020
4136166
Error checking for no or multiple equals sign (=) error
seongm-1 Apr 23, 2020
1c57979
Refactored code for role flag issues
seongm-1 Apr 27, 2020
685b76d
Changed documentation
seongm-1 Apr 27, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
10 changes: 8 additions & 2 deletions ecs-cli/modules/utils/utils.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,11 @@ import (

const (
// ECSCLIResourcePrefix is prepended to the names of resources created through the ecs-cli
ECSCLIResourcePrefix = "amazon-ecs-cli-setup-"
ECSCLIResourcePrefix = "amazon-ecs-cli-setup-"
containerNameParamKey = "containerName"
seongm-1 marked this conversation as resolved.
Show resolved Hide resolved
containerPortParamKey = "containerPort"
loadBalancerNameParamKey = "loadBalancerName"
targetGroupArnParamKey = "targetGroupArn"
)

// InSlice checks if the given string exists in the given slice:
Expand Down Expand Up @@ -115,7 +119,8 @@ func ParseLoadBalancers(flagValues []string) ([]*ecs.LoadBalancer, error) {

seongm-1 marked this conversation as resolved.
Show resolved Hide resolved
for _, flagValue := range flagValues {
m := make(map[string]string)
validFlags := []string{"targetGroupArn", "loadBalancerName", "containerName", "containerPort"}

validFlags := []string{containerNameParamKey, containerPortParamKey, loadBalancerNameParamKey, targetGroupArnParamKey}
currentFlags := map[string]bool{
"containerName": false,
"containerPort": false,
Expand All @@ -130,6 +135,7 @@ func ParseLoadBalancers(flagValues []string) ([]*ecs.LoadBalancer, error) {
if len(pair) > 2 {
seongm-1 marked this conversation as resolved.
Show resolved Hide resolved
return nil, fmt.Errorf("Only include one = to indicate your value in your %s", key)
}

if ok := contains(validFlags, key); !ok {
return nil, fmt.Errorf("[--%s] is an invalid flag", key)
}
Expand Down