-
Notifications
You must be signed in to change notification settings - Fork 175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update to newer k8s 1.25.6 as vendored dependency #170
Update to newer k8s 1.25.6 as vendored dependency #170
Conversation
0442e32
to
0a9ff4e
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
0a9ff4e
to
9626c7d
Compare
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
9626c7d
to
d432ad8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
thanks @nckturner merging now. |
@@ -36,7 +36,7 @@ import ( | |||
v1 "k8s.io/client-go/informers/core/v1" | |||
"k8s.io/client-go/kubernetes" | |||
"k8s.io/client-go/tools/clientcmd" | |||
"k8s.io/klog" | |||
"k8s.io/klog/v2" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Signed-off-by: Davanum Srinivas davanum@gmail.com
Issue #, if available:
Description of changes:
We are on a old version of k8s, let us please switch to a newer version.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.