Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to newer k8s 1.25.6 as vendored dependency #170

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

dims
Copy link
Member

@dims dims commented Feb 1, 2023

Signed-off-by: Davanum Srinivas davanum@gmail.com

Issue #, if available:

Description of changes:

We are on a old version of k8s, let us please switch to a newer version.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dims dims requested a review from a team as a code owner February 1, 2023 19:31
@dims dims force-pushed the update-to-k8s-1.25.6-as-vendored-dependency branch 4 times, most recently from 0442e32 to 0a9ff4e Compare February 1, 2023 19:44
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-to-k8s-1.25.6-as-vendored-dependency branch from 0a9ff4e to 9626c7d Compare February 1, 2023 19:50
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims force-pushed the update-to-k8s-1.25.6-as-vendored-dependency branch from 9626c7d to d432ad8 Compare February 1, 2023 20:04
Copy link
Contributor

@nckturner nckturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dims
Copy link
Member Author

dims commented Feb 1, 2023

thanks @nckturner merging now.

@dims dims merged commit f7841c8 into aws:master Feb 1, 2023
@@ -36,7 +36,7 @@ import (
v1 "k8s.io/client-go/informers/core/v1"
"k8s.io/client-go/kubernetes"
"k8s.io/client-go/tools/clientcmd"
"k8s.io/klog"
"k8s.io/klog/v2"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :)

Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants