Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add tests for grpc health probes and seccompProfile #171

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

dims
Copy link
Member

@dims dims commented Feb 1, 2023

Signed-off-by: Davanum Srinivas davanum@gmail.com

Issue #, if available:

Description of changes:
Adding a test to ensure we don't break scenario in #165 and #168

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

PS: the last commit missed a file in vendor/ adding it here.

@dims dims requested a review from a team as a code owner February 1, 2023 20:17
Signed-off-by: Davanum Srinivas <davanum@gmail.com>
@dims dims changed the title add a test for grpc health probes add a test for grpc health probes and seccompProfile Feb 1, 2023
@dims dims changed the title add a test for grpc health probes and seccompProfile add tests for grpc health probes and seccompProfile Feb 1, 2023
@nckturner nckturner merged commit b6d115f into aws:master Feb 1, 2023
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants