patch pod spec even if it's already been patched #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
before, the updatePodSpec function would return immediately if it detected that the aws-iam-token volume was already present. This patch modifies the behavior so that the function continues to inject environment variables and volume mounts as needed. Specifically, the behavior of injecting env vars, volume mounts, and volumes is now: 1. For each env var in "AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE, AWS_REGION, AWS_DEFAULT_REGION", inject if not already present in container spec 2. Inject volume mount if not already present in container spec 3. Inject volume if not already present in pod spec
|
@micahhausler I think folks who want to adopt pod-identity-webhook and use the sidecar pattern will find this useful. Could someone take a look? |
josselin-c
reviewed
Oct 6, 2020
josselin-c
suggested changes
Oct 6, 2020
yangkev
commented
Oct 13, 2020
|
Hi guys, i think i'm hitting this issue in our EKS cluster, how do we know if this fix is in our EKS cluster? I couldn't find any information on releases. thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, the updatePodSpec function would return immediately if it detected that the
aws-iam-token volume was already present.
This patch modifies the behavior so that the function continues to
inject environment variables and volume mounts as needed.
Specifically, the behavior of injecting env vars, volume mounts, and
volumes is now:
For each env var in "AWS_ROLE_ARN, AWS_WEB_IDENTITY_TOKEN_FILE,
AWS_REGION, AWS_DEFAULT_REGION", inject if not already present in
container spec
Inject volume mount if not already present in container spec
Inject volume if not already present in pod spec
Fixes #61