Refactor LPnorm #19
Merged
Refactor LPnorm #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pinaraws
requested changes
Jul 14, 2020
| else: | ||
| lp_norm = -1.0 | ||
| assert False, "Histogram length differ when calculating PDF." |
There was a problem hiding this comment.
Typo
Histogram length differ => Histogram lengths are different
Also please use "raise ValueError" instead
There was a problem hiding this comment.
I knew you would comment :-), but it's an assert because it can't happen by user input, as the size of the histogram is fixed by us. If it would happen it would be a bug in our case.
pinaraws
approved these changes
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Improve LPnorm documentation and error handling.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.