[bugfix] Fix JS metric #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AnkitSiva
reviewed
Feb 10, 2021
pinaraws
requested changes
Feb 11, 2021
xgchena
reviewed
Feb 11, 2021
milah
force-pushed
the
fix-js
branch
2 times, most recently
from
fe6d4ec
to
e106f24
Compare
pinaraws
approved these changes
Feb 12, 2021
xgchena
approved these changes
Feb 12, 2021
keerthanvasist
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: P44014016
Description of changes:
According to our developer guide for JS metric (which is aligned with the formula on wiki Jensen-Shannon divergence)
The formula for the Jensen-Shannon divergence is as follows:
JS = ½*[KL(Pa || P) + KL(Pd || P)]
Where P = ½( Pa + Pd ), the average label distribution across facets a and d.
Instead we currently use the label distribution in the dataset. This PR fixes this bug reported by Xiaoguang.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.
Tested: used in the Container as package.