Wait for ENI and secondary IPs #1131
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, @mogren. LGTM 👍 |
mogren
force-pushed
the
dont-log-limit-exceeded-as-error
branch
5 times, most recently
from
524f508
to
a68b1bb
Compare
mogren
force-pushed
the
dont-log-limit-exceeded-as-error
branch
from
a68b1bb
to
64f2853
Compare
mogren
changed the title
mogren
force-pushed
the
dont-log-limit-exceeded-as-error
branch
6 times, most recently
from
72290ea
to
0613a65
Compare
When a newly created ENI gets attached, we should wait for the secondary IPv4 addresses to be assigned to the ENI before continuing.
mogren
force-pushed
the
dont-log-limit-exceeded-as-error
branch
from
0613a65
to
ed5a4ad
Compare
|
Replaced by #1174 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#989, #1148
Description of changes:
The log statements helping us find #989 were added earlier this year in #909 and #939, but the issue has probably been there longer. The problem is detailed in #1148, we need to wait for the Secondary IPv4 addresses to show up in the EC2 response. This PR does the following:
waitENIAttached()fromipamd.gotoawsutils.goBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.