Reduce number of calls to EC2 API #909
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mogren
force-pushed
the
less-ec2-calls
branch
2 times, most recently
from
480a226
to
b492bba
Compare
mogren
commented
Apr 11, 2020
jaypipes
suggested changes
Apr 13, 2020
mogren
force-pushed
the
less-ec2-calls
branch
3 times, most recently
from
cd55c21
to
dde2d35
Compare
mogren
force-pushed
the
less-ec2-calls
branch
5 times, most recently
from
aa34f6f
to
df7a23a
Compare
jaypipes
added a commit
to jaypipes/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 17, 2020
Practice good code safety in the `EC2MetadataCache.getENIAttachmentID()` method by not assuming that either the `DescribeNetworkInterfacesOutput` struct's `NetworkInterfaces` field is not empty and that the first `NetworkInterface` struct that collection has a non-nil `Attachment` field. Fixes Issue aws#914 however note that with aws#909, the source code changed dramatically and this patch will need to be written differently for v1.5.x branches.
mogren
pushed a commit
that referenced
this pull request
Apr 17, 2020
Practice good code safety in the `EC2MetadataCache.getENIAttachmentID()` method by not assuming that either the `DescribeNetworkInterfacesOutput` struct's `NetworkInterfaces` field is not empty and that the first `NetworkInterface` struct that collection has a non-nil `Attachment` field. Fixes Issue #914 however note that with #909, the source code changed dramatically and this patch will need to be written differently for v1.5.x branches.
mogren
pushed a commit
to mogren/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 20, 2020
mogren
pushed a commit
to mogren/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 20, 2020
Practice good code safety in the `EC2MetadataCache.getENIAttachmentID()` method by not assuming that either the `DescribeNetworkInterfacesOutput` struct's `NetworkInterfaces` field is not empty and that the first `NetworkInterface` struct that collection has a non-nil `Attachment` field. Fixes Issue aws#914 however note that with aws#909, the source code changed dramatically and this patch will need to be written differently for v1.5.x branches.
mogren
pushed a commit
that referenced
this pull request
Apr 20, 2020
mogren
pushed a commit
that referenced
this pull request
Apr 20, 2020
Practice good code safety in the `EC2MetadataCache.getENIAttachmentID()` method by not assuming that either the `DescribeNetworkInterfacesOutput` struct's `NetworkInterfaces` field is not empty and that the first `NetworkInterface` struct that collection has a non-nil `Attachment` field. Fixes Issue #914 however note that with #909, the source code changed dramatically and this patch will need to be written differently for v1.5.x branches.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #887
Description of changes:
currentENIsvalue since it's not used anywhereAttachmentIDfrom EC2no_manageno_managetags on both restarts and adding new ENIs to a nodeTest showing number of
DescribeNetworkInterfacescalls running 5000 pods on 100 nodes:By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.