Add support for collecting Aperf Run logs #232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash-amzn
reviewed
Sep 27, 2024
Comment on lines
+52
to
+58
| "[{d(%Y-%m-%dT%H:%M:%SZ)} {h({l}):5.5} {M}] {m}{n}", | ||
| ))) | ||
| .build(); | ||
|
|
||
| let fileout = FileAppender::builder() | ||
| .encoder(Box::new(PatternEncoder::new( | ||
| "[{d(%Y-%m-%dT%H:%M:%SZ)} {h({l}):5.5} {M}] {m}{n}", |
There was a problem hiding this comment.
Unless you intend the patterns to diverge, factor out the PatternEncoder so it's not written twice.
| @@ -24,6 +24,7 @@ | |||
| <button class="tablinks" name="interrupts">Interrupt Data</button> | |||
| <button class="tablinks" name="disk_stats">Disk Stats</button> | |||
| <button class="tablinks" name="netstat">Net Stats</button> | |||
| <button class="tablinks" name="aperfrunlog">Aperf Runlog</button> | |||
There was a problem hiding this comment.
We're already at too many tabs. They can be vertically shrunk some to buy time, but I think we'll have to start collapsing some of this. For example, just have a single 'Internals' tab, under which there are the aperf internal stats and now runlog (possibly via a sub-tab).
|
We're going to want to configure different levels for the stdout vs file loggers (and the command-line option for verbosity should not affect the file log). Make sure you can at least do that with the current design. Trace level would be awesome for the file log, but at least debug level. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switch to using log4rs crate which allows all prints from aperf to be shown both in the console and a file. This file can be used to see the run prints during the record phase. Attached a report with the runlog.
kbuildlog.tar.gz
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.