Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Active to False in more situations #18

Closed
nckturner opened this issue Mar 22, 2019 · 1 comment
Closed

Update Active to False in more situations #18

nckturner opened this issue Mar 22, 2019 · 1 comment
Assignees

Comments

@nckturner
Copy link
Contributor

nckturner commented Mar 22, 2019

The Active condition for each resource is created and updated to true when the resource is created. Additionally, it is updated to false in the case where a describe call returns "Deleted" or "Inactive". However, in the case where the Mesh custom resource is deleted, which in turn deletes all resources in the mesh from the App Mesh API, we do not mark the statuses to false because the resource processing quits early due to this check in virtual node (a similar one exists in virtual service):

	if processVNode := c.handleVNodeMeshDeleting(ctx, vnode); !processVNode {
		klog.Infof("skipping processing virtual node %s", vnode.Name)
		return nil
	}

There are probably more cases where we should.

@achevuru
Copy link
Contributor

achevuru commented Jun 3, 2020

Not applicable for GA version. Mesh delete will not trigger the delete of VNs, VSs.

@achevuru achevuru closed this as completed Jun 3, 2020
jeremymill added a commit to jeremymill/aws-app-mesh-controller-for-k8s that referenced this issue Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants