fix(core): improve error message if construct names conflict (#1706)

aws · Feb 8, 2019 · 0ea4a78 · 0ea4a78
1 parent 07d9909
commit 0ea4a78
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 2 deletions.
diff --git a/packages/@aws-cdk/cdk/lib/core/construct.ts b/packages/@aws-cdk/cdk/lib/core/construct.ts
@@ -374,7 +374,8 @@ export class ConstructNode {
     }
 
     if (childName in this._children) {
-      throw new Error(`There is already a Construct with name '${childName}' in ${this.toString()}`);
+      const name = this.id || '';
+      throw new Error(`There is already a Construct with name '${childName}' in ${this.typename}${name.length > 0 ? ' [' + name + ']' : ''}`);
     }
 
     this._children[childName] = child;

diff --git a/packages/@aws-cdk/cdk/test/core/test.construct.ts b/packages/@aws-cdk/cdk/test/core/test.construct.ts
@@ -209,7 +209,16 @@ export = {
     // THEN: They have different paths
     test.throws(() => {
       new Construct(root, 'SameName');
-    });
+    }, /There is already a Construct with name 'SameName' in Root/);
+
+    // WHEN
+    const c0 = new Construct(root, 'c0');
+    new Construct(c0, 'SameName');
+
+    // THEN: They have different paths
+    test.throws(() => {
+      new Construct(c0, 'SameName');
+    }, /There is already a Construct with name 'SameName' in Construct \[c0\]/);
 
     test.done();
   },