fix(apigateway): authorizer name is not optional (#5731)

The authorizer name property is marked as optional in CloudFormation docs but is actually not. Use the TokenAuthorizer node's uniquId as the default. fixes #5678 Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
aws · Jan 9, 2020 · 21c425e · 21c425e
1 parent c53356a
commit 21c425e
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 2 deletions.
diff --git a/packages/@aws-cdk/aws-apigateway/lib/authorizers/lambda.ts b/packages/@aws-cdk/aws-apigateway/lib/authorizers/lambda.ts
@@ -13,7 +13,7 @@ export interface TokenAuthorizerProps {
   /**
    * An optional human friendly name for the authorizer. Note that, this is not the primary identifier of the authorizer.
    *
-   * @default - none
+   * @default this.node.uniqueId
    */
   readonly authorizerName?: string;
 
@@ -92,7 +92,7 @@ export class TokenAuthorizer extends Authorizer implements IAuthorizer {
     const restApiId = Lazy.stringValue({ produce: () => this.restApiId });
 
     const resource = new CfnAuthorizer(this, 'Resource', {
-      name: props.authorizerName,
+      name: props.authorizerName ?? this.node.uniqueId,
       restApiId,
       type: 'TOKEN',
       authorizerUri: `arn:aws:apigateway:${Stack.of(this).region}:lambda:path/2015-03-31/functions/${props.handler.functionArn}/invocations`,

diff --git a/...es/@aws-cdk/aws-apigateway/test/authorizers/integ.token-authorizer-iam-role.expected.json b/...es/@aws-cdk/aws-apigateway/test/authorizers/integ.token-authorizer-iam-role.expected.json
@@ -105,6 +105,7 @@
     "MyAuthorizer6575980E": {
       "Type": "AWS::ApiGateway::Authorizer",
       "Properties": {
+        "Name": "TokenAuthorizerIAMRoleIntegMyAuthorizer1DFDE3B5",
         "RestApiId": {
           "Ref": "MyRestApi2D1F47A9"
         },

diff --git a/packages/@aws-cdk/aws-apigateway/test/authorizers/integ.token-authorizer.expected.json b/packages/@aws-cdk/aws-apigateway/test/authorizers/integ.token-authorizer.expected.json
@@ -199,6 +199,7 @@
     "MyAuthorizer6575980E": {
       "Type": "AWS::ApiGateway::Authorizer",
       "Properties": {
+        "Name": "TokenAuthorizerIntegMyAuthorizer793B1D5F",
         "RestApiId": {
           "Ref": "MyRestApi2D1F47A9"
         },