Skip to content

Commit

Permalink
fix: Npm ignores files and folders named "core" by default (#1767)
Browse files Browse the repository at this point in the history
Since the release of `npm@6.8.0`, a version of `npm-packlist` is
included that introduces a behavior to ignore anything named "core" by
default.

Added `!core` to the `.npmignore` file as a work around, and also more
strictly pinned the `npm` version to auto-upgrade to so we don't get
surprised in this kind of way anymore.

Cause: npm/npm-packlist#24
  • Loading branch information
RomainMuller committed Feb 14, 2019
1 parent 73d5bef commit 42876e7
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 2 deletions.
2 changes: 1 addition & 1 deletion install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export NODE_OPTIONS="--max-old-space-size=4096 ${NODE_OPTIONS:-}"

if ! npm ci --help; then
echo "upgrading npm, because "npm ci" is not supported"
npm i -g npm
npm i -g npm@~6.8.0
fi

echo "============================================================================================="
Expand Down
5 changes: 4 additions & 1 deletion packages/@aws-cdk/cdk/.npmignore
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,7 @@ dist
# Include .jsii
!.jsii

*.snk
*.snk

# Work around npm@6.8.0 ignoring 'core' by default -- https://github.com/npm/npm-packlist/issues/24
!core

0 comments on commit 42876e7

Please sign in to comment.