Skip to content

Commit

Permalink
chore: pr-build failing with unsafe-perm is not a valid npm option (#…
Browse files Browse the repository at this point in the history
…28068)

We switched the images used to build PRs to `jsii/superchain:bullseye-slim-node18` which comes with Node.js 18 instead of Node.js 16. This Node.js upgrade also includes an upgraded version of npm, and in recent npm versions, the unsef-perm option is not required anymore. This change simply removes the now redundant command.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
mrgrain authored and rix0rrr committed Nov 21, 2023
1 parent 1cc484b commit 8f5e319
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions buildspec-pr.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -14,9 +14,6 @@ phases:
# this also takes care of launching the docker daemon.
- /root/ecr-proxy/start.sh

# CodeBuild always runs as root, allow npm to operate as such
- npm config set unsafe-perm true

# Install yarn if it wasn't already present in the image
- yarn --version || npm -g install yarn

Expand Down

0 comments on commit 8f5e319

Please sign in to comment.