Skip to content

Commit

Permalink
fix(build): Prereq check - support paths with spaces.
Browse files Browse the repository at this point in the history
Prereq check before `yarn build` fails when there are spaces in the
path. This is common for WSL2 on windows. For example, mvn is in the
path at `/mnt/c/Program Files/`.

Testing - Ran check on linux paths and windows paths with and without
spaces. Tested with correct version, wrong version, and missing dep.

fixes #9749
  • Loading branch information
thantos committed Aug 16, 2020
1 parent 5af718b commit 9ca1d02
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion scripts/check-prerequisites.sh
Expand Up @@ -22,7 +22,7 @@ check_which() {

w=$(which ${app}) || w=""

if [ -z $w ] || [ $w == "$app not found" ]
if [ -z "$w" ] || [ "$w" == "$app not found" ]
then
die "Missing dependency: $app. Install $app >= $min"
else
Expand Down

0 comments on commit 9ca1d02

Please sign in to comment.