Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[build] - Prereq check does not support paths with spaces. #9749

Closed
thantos opened this issue Aug 16, 2020 · 0 comments · Fixed by #9750
Closed

[build] - Prereq check does not support paths with spaces. #9749

thantos opened this issue Aug 16, 2020 · 0 comments · Fixed by #9750
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@thantos
Copy link
Contributor

thantos commented Aug 16, 2020 •
edited

Running yarn build as documented in CONTRIBUTING fails when there is a space in the path. Specifically, running from WSL2 and maven (mvn) is found in /mnt/c/Program Files.

Reproduction Steps

  • WSL2
  • mvn is installed in windows partition and in the WSL2 path.
  • yarn build or ./scripts/check-prerequisites.sh

What did you expect to happen?

Expected to check the mvn version and either fail due to incorrect version or succeed on correct version.

What actually happened?

Checking if mvn is installed... ./scripts/check-prerequisites.sh: line 25: [: /mnt/c/Program: binary operator expected
./scripts/check-prerequisites.sh: line 25: [: too many arguments
Ok

Environment

  • CLI Version : 1.59
  • Framework Version: 1.59
  • Node.js Version: 10
  • OS : Windows 10 - WSL2 - Ubuntu 20.04
  • Language (Version): all

Other

PR: #9750

This is 🐛 Bug Report
@thantos thantos added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 16, 2020
@thantos thantos mentioned this issue Aug 16, 2020
Merged
NetaNir pushed a commit that referenced this issue Aug 17, 2020
@thantos
fix(build): Prereq check - support paths with spaces.
9ca1d02 
Prereq check before `yarn build` fails when there are spaces in the
path. This is common for WSL2 on windows. For example, mvn is in the
path at `/mnt/c/Program Files/`.

Testing - Ran check on linux paths and windows paths with and without
spaces. Tested with correct version, wrong version, and missing dep.

fixes #9749
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(core): Prereq check - support paths with spaces. thantos/aws-cdk
1 participant
@thantos