feat(s3-deployment): support vpc in BucketDeploymentProps #12035
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
iliapolo
previously requested changes
Dec 13, 2020
iliapolo
added
pr-linter/exempt-readme
- user can now pass in a vpc construct as part of BucketDeploymentProps - closes aws#11734
mergify
bot
dismissed
iliapolo’s stale review
Pull request has been modified.
iliapolo
approved these changes
Dec 13, 2020
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
iliapolo
removed
the
response-requested
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
flochaz
pushed a commit
to flochaz/aws-cdk
that referenced
this pull request
Jan 5, 2021
- user can now pass in a vpc construct as part of BucketDeploymentProps - closes aws#11734 Could we please decorate this PR with the pr-linter/exempt-readme label? I don't think this is a big enough feature to add README content. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could we please decorate this PR with the pr-linter/exempt-readme label? I don't think this is a big enough feature to add README content.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license