fix(eks): aws-node-termination-handler incorrectly deployed to on-demand instances as well

[dirknilius]

fixes #12368

The former implementation was using the string format for submitting Helm values in the CLI (parent.child=value). This does not work here as JavaScript does not expand the string. We need to define the values is the correct hierarchy.

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[iliapolo]

@dirknilius Sweet, thanks!

Pull request has been modified.

[dirknilius]

@iliapolo Hey,

somehow the CodeBuild failed. Unfortunately I cannot download the logs. It just loads with a few kb/s and then stops. I am also not able to run the tests in Gitpod. The docs (CONTRIBUTING.md) states I have to run yarn build. But this cannot work as there is no Docker installed. Also the partial build relies on Docker. How could this work?

[iliapolo]

@dirknilius It was just some linting stuff:

@aws-cdk/aws-cloudwatch-actions: Done in 24.53s.
@aws-cdk/aws-eks: /codebuild/output/src958570000/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-eks/lib/cluster.ts
@aws-cdk/aws-eks:   1453:24  error  Missing space before value for key 'nodeSelector'  key-spacing
@aws-cdk/aws-eks:   1455:12  error  Missing trailing comma                             comma-dangle
@aws-cdk/aws-eks: ✖ 2 problems (2 errors, 0 warnings)
@aws-cdk/aws-eks:   2 errors and 0 warnings potentially fixable with the `--fix` option.
@aws-cdk/aws-eks: Error: /codebuild/output/src958570000/src/github.com/aws/aws-cdk/node_modules/esli

I got this from the Build Logs link of the CodeBuild report, not sure why it didn't open for you...as for the gitpod and partial build, i'll take a look.

I took the liberty and just committed a fix from the review UI, so hopefully it will get merged soon.

Thanks!

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
• Commit ID: 2fb224a
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).