fix(ec2): Throw error on empty InitFile content (#13009) #13119
Conversation
Validate InitFile content to catch error during synth instead of deploy. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
|
github-actions
bot
added
the
@aws-cdk/aws-ec2
| @@ -206,6 +206,12 @@ describe('InitFile', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| test('empty content string throws error', () => { | |||
| expect(() => { | |||
| ec2.InitFile.symlink('/tmp/foo', ''); | |||
There was a problem hiding this comment.
Why have you changed fromString and are you testing symlink ?
| @@ -327,6 +327,9 @@ export abstract class InitFile extends InitElement { | |||
| * Use a literal string as the file content | |||
| */ | |||
| public static fromString(fileName: string, content: string, options: InitFileOptions = {}): InitFile { | |||
| if (!content) { | |||
| throw new Error('Content was empty'); | |||
There was a problem hiding this comment.
This could be more descriptive, at least referencing the file that was trying to be created. Also, we like our error messages to suggest a clear path forward.
How about:
InitFile ${fileName}: cannot create empty file. Please supply at least one character of content.
There was a problem hiding this comment.
Good suggestion, fixed.
mergify
bot
dismissed
rix0rrr’s stale review
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Validate InitFile content to catch error during synth instead of deploy. Fixes issue #13009
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license