-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cloudformation): update integration tests with description parameter for custom resources #13276
Conversation
…meter for custom resources
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really mind shipping this, but would you mind elaborating on the motivation somewhat?
Sorry about that @rix0rrr .... Updated the original PR. |
Pull request has been modified.
@rix0rrr I wasn't sure if cross-module commits are allowed so I split them into two separate ones. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Integration test in
core
module requires that any custom description parameter integration tests should be done incloudformation
module.https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/core/test/integration.custom-resources.readme
Depends on #13275
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license