-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lambda-event-sources): tumbling window #13412
feat(lambda-event-sources): tumbling window #13412
Conversation
Updated DynamoDB and Kinesis events sources, associated tests and README
Updated DynamoDB and Kinesis events sources, associated tests and README
…thub.com/msimpsonnz/aws-cdk into msimpsonnz/feature-lambda-tumblingwindow
fix naming issue due to failing lint test
Hello - Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @msimpsonnz - Thanks for submitting this PR.
Please see my comments below.
packages/@aws-cdk/aws-lambda-event-sources/test/test.kinesis.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
…thub.com/msimpsonnz/aws-cdk into msimpsonnz/feature-lambda-tumblingwindow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @msimpsonnz -
Code looks great but it looks like there are some merge conflicts with the latest commits on master. Can you resolve these and re-submit?
@nija-at I’ve resolved the conflict. Had to fight with Gitpod for a while but managed to get it sorted |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
fixes aws#13411 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes aws#13411 *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
fixes #13411
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license