Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(lambda-event-sources): tumbling window #13412

Merged
merged 19 commits into from
Mar 26, 2021
Merged

feat(lambda-event-sources): tumbling window #13412

merged 19 commits into from
Mar 26, 2021

Conversation

msimpsonnz
Copy link
Contributor

fixes #13411

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 5, 2021 •
edited
Loading

@github-actions github-actions bot added the @aws-cdk/aws-lambda Related to AWS Lambda label Mar 5, 2021
@msimpsonnz
feat(aws-lambda-event-sources): Add tumblingWindowInSeconds option
bb48223 
Updated DynamoDB and Kinesis events sources, associated tests and README
@msimpsonnz
feat(aws-lambda-event-sources): Add tumblingWindowInSeconds option
bc3249e 
Updated DynamoDB and Kinesis events sources, associated tests and README
@msimpsonnz
Merge branch 'msimpsonnz/feature-lambda-tumblingwindow' of https://gi…
f2a3a2e 
…thub.com/msimpsonnz/aws-cdk into msimpsonnz/feature-lambda-tumblingwindow
@msimpsonnz
feat(aws-lambda-event-sources): Add tumblingWindowInSeconds option
5a09e1e 
fix naming issue due to failing lint test
@nija-at
Copy link
Contributor

nija-at commented Mar 17, 2021

Hello -

Sorry about the delay in reviewing PRs. We are experiencing an increased backlog of items that need our attention.
We will get to your PR as soon as we are able to. Apologies for the delay.

nija-at
nija-at previously requested changes Mar 22, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msimpsonnz - Thanks for submitting this PR.

Please see my comments below.

packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/lib/stream.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.dynamo.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.kinesis.ts Show resolved Hide resolved
packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.dynamo.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-lambda-event-sources/test/test.kinesis.ts Outdated Show resolved Hide resolved
@nija-at nija-at changed the title feat(aws-lambda): Add tumblingWindowInSeconds to Lambda Event Source feat(lambda-event-sources): tumbling window Mar 22, 2021
@msimpsonnz
Update packages/@aws-cdk/aws-lambda/lib/event-source-mapping.ts
0f3c135 
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
@mergify mergify bot dismissed nija-at’s stale review March 22, 2021 19:41

Pull request has been modified.

nija-at
nija-at previously approved these changes Mar 25, 2021
View reviewed changes
@nija-at nija-at dismissed their stale review March 25, 2021 14:19

merge conflicts

nija-at
nija-at previously requested changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @msimpsonnz -

Code looks great but it looks like there are some merge conflicts with the latest commits on master. Can you resolve these and re-submit?

@mergify mergify bot dismissed nija-at’s stale review March 26, 2021 01:42

Pull request has been modified.

@msimpsonnz
Copy link
Contributor Author

@nija-at I’ve resolved the conflict. Had to fight with Gitpod for a while but managed to get it sorted

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e5a4e4d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 26, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit e9f2773 into aws:master Mar 26, 2021
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Mar 31, 2021
@msimpsonnz @hollanddd
feat(lambda-event-sources): tumbling window (aws#13412)
088ec19 
fixes aws#13411

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@msimpsonnz msimpsonnz deleted the msimpsonnz/feature-lambda-tumblingwindow branch April 13, 2021 05:10
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@msimpsonnz @hollanddd
feat(lambda-event-sources): tumbling window (aws#13412)
c502a1a 
fixes aws#13411

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
@aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/aws-lambda-event-sources
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(aws-lambda): Add tumblingWindowInSeconds to Lambda Event Source Mapping
3 participants
@msimpsonnz @nija-at @aws-cdk-automation