fix(iam): Role import doesn't fail when forgetting the region in the ARN #13821
Conversation
If you forget the region part of the ARN for an IAM resource like a Role (and considering the region is never provided for IAM resources, it's easy to forget, as you have to provide it as `::`), the IAM library doesn't catch this error, and you only find out about it at deployment time, with a very confusing `Fn::Select cannot select nonexistent value at index 5` message from CloudFormation. Re-factor the ARN parsing code in core a little bit to allow us to catch this common error. Fixes aws#13812
|
|
github-actions
bot
added
the
@aws-cdk/aws-iam
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ARN (aws#13821) If you forget the region part of the ARN for an IAM resource like a Role (and considering the region is never provided for IAM resources, it's easy to forget, as you have to provide it as `::`), the IAM library doesn't catch this error, and you only find out about it at deployment time, with a very confusing `Fn::Select cannot select nonexistent value at index 5` message from CloudFormation. Re-factor the ARN parsing code in core a little bit to allow us to catch this common error. Fixes aws#13812 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ARN (aws#13821) If you forget the region part of the ARN for an IAM resource like a Role (and considering the region is never provided for IAM resources, it's easy to forget, as you have to provide it as `::`), the IAM library doesn't catch this error, and you only find out about it at deployment time, with a very confusing `Fn::Select cannot select nonexistent value at index 5` message from CloudFormation. Re-factor the ARN parsing code in core a little bit to allow us to catch this common error. Fixes aws#13812 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
If you forget the region part of the ARN for an IAM resource like a Role
(and considering the region is never provided for IAM resources,
it's easy to forget, as you have to provide it as
::),the IAM library doesn't catch this error,
and you only find out about it at deployment time,
with a very confusing
Fn::Select cannot select nonexistent value at index 5message from CloudFormation.
Re-factor the ARN parsing code in core a little bit to allow us to catch this common error.
Fixes #13812
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license