Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(dynamodb): add ability to enable contributor insights on Table #14742

Merged
merged 9 commits into from
May 19, 2021
Merged

feat(dynamodb): add ability to enable contributor insights on Table #14742

merged 9 commits into from
May 19, 2021

Conversation

sudo-ryan
Copy link
Contributor

@sudo-ryan sudo-ryan commented May 18, 2021 •
edited
Loading

Resolve #11626

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 18, 2021

@github-actions github-actions bot added the @aws-cdk/aws-dynamodb Related to Amazon DynamoDB label May 18, 2021
skinny85
skinny85 previously requested changes May 18, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this contribution @sudo-ryan! I have a few small comments, but in general looks great!

packages/@aws-cdk/aws-dynamodb/lib/table.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-dynamodb/test/dynamodb.test.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-dynamodb/test/dynamodb.test.ts Outdated Show resolved Hide resolved
@skinny85 skinny85 changed the title feat(aws-dynamodb): add ability to enable contributor insights on table feat(dynamodb): add ability to enable contributor insights on Table May 18, 2021
@mergify mergify bot dismissed skinny85’s stale review May 19, 2021 08:16

Pull request has been modified.

skinny85
skinny85 approved these changes May 19, 2021
View reviewed changes
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks @sudo-ryan!

@skinny85 skinny85 added the pr-linter/exempt-readme The PR linter will not require README changes label May 19, 2021
@mergify
Copy link
Contributor

mergify bot commented May 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 84f5793
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3c7a89d into aws:master May 19, 2021
@mergify
Copy link
Contributor

mergify bot commented May 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@arnab arnab mentioned this pull request Jun 11, 2021
Open
2 tasks
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
@sudo-ryan @hollanddd
feat(dynamodb): add ability to enable contributor insights on Table (a…
e073353 
…ws#14742)

Resolve aws#11626

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skinny85 skinny85 skinny85 approved these changes

Assignees

@RomainMuller RomainMuller

Labels
@aws-cdk/aws-dynamodb Related to Amazon DynamoDB pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DynamoDb]: Add support DynamoDb Contributer Insights
4 participants
@sudo-ryan @aws-cdk-automation @skinny85 @RomainMuller