Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-stepfunctions): Add support to States.HeartbeatTimeout #16084

Closed
1 of 2 tasks
diegotry opened this issue Aug 17, 2021 · 1 comment · Fixed by #16078
Closed
1 of 2 tasks

(aws-stepfunctions): Add support to States.HeartbeatTimeout #16084

diegotry opened this issue Aug 17, 2021 · 1 comment · Fixed by #16078
Assignees
@BenChaimberg
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@diegotry
Copy link
Contributor

diegotry commented Aug 17, 2021 •
edited
Loading

Currently Step Functions only supports a Catch on States.Timeout that includes both Task timeout and Task Heartbeat timeout. Recently, Step Functions included a new error type called States.HeartbeatTimeout where customers can have a different error handling logic for this specific case.

Use Case

Customers want to retry on heartbeat timeout as it implies there was a worker failure.

Proposed Solution

Add the support to the new States.HeartbeatTimeout issue

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

Pull request: #16078

This is a 🚀 Feature Request
@diegotry diegotry added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Aug 17, 2021
@diegotry diegotry mentioned this issue Aug 17, 2021
Merged
@BenChaimberg BenChaimberg added effort/small Small work item – less than a day of effort p2 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 18, 2021
@mergify mergify bot closed this as completed in #16078 Aug 18, 2021
mergify bot pushed a commit that referenced this issue Aug 18, 2021
@diegotry
feat(aws-stepfunctions): add support to heartbeat error inside catch …
2372b3c 
…block (#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes #16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

smguggen pushed a commit to smguggen/aws-cdk that referenced this issue Aug 24, 2021
@diegotry @smguggen
feat(aws-stepfunctions): add support to heartbeat error inside catch …
85586e4 
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@diegotry @hollanddd
feat(aws-stepfunctions): add support to heartbeat error inside catch …
a2f149f 
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Sep 6, 2021
@diegotry @TikiTDO
feat(aws-stepfunctions): add support to heartbeat error inside catch …
70f69c7 
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this issue Sep 7, 2021
@diegotry @david-doyle-as24
feat(aws-stepfunctions): add support to heartbeat error inside catch …
d5df2b4 
…block (aws#16078)

Step Functions recently added a feature to catch States.HeartbeatTimeout. This change adds support to that.

https://docs.aws.amazon.com/step-functions/latest/dg/concepts-error-handling.html

closes aws#16084

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BenChaimberg BenChaimberg

Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(aws-stepfunctions): add support to heartbeat error inside catch block diegotry/aws-cdk
2 participants
@BenChaimberg @diegotry