Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(cli): .gitignore is not generated during cdk init app from v2.14 or later #19460

Closed
konokenj opened this issue Mar 18, 2022 · 3 comments · Fixed by #19482
Closed

(cli): .gitignore is not generated during cdk init app from v2.14 or later #19460

konokenj opened this issue Mar 18, 2022 · 3 comments · Fixed by #19482
Assignees
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1 package/tools Related to AWS CDK Tools or CLI

Comments

@konokenj
Copy link
Contributor

What is the problem?

.gitignore is missing after cdk init app --language=typescript in v2.14.0. It exists in v2.13.0.
This problems still exists in latest version (v2.17.0).

Reproduction Steps

# .gitignore is missing
npx aws-cdk@2.14 init app --generate-only --language=typescript
# .gitignore exists
npx aws-cdk@2.13 init app --generate-only --language=typescript

What did you expect to happen?

Initialize project with correctly.

What actually happened?

Since the.gitignore does not exist, node_modules are committed to git. To avoid this, it is necessary to copy the.gitignore generated by the previous version.

CDK CLI Version

2.14.0 (build 762d71b)

Framework Version

No response

Node.js Version

v16.3.0

OS

macOS Big Sur 11.6.4

Language

Typescript

Language Version

No response

Other information

No response

@konokenj konokenj added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 18, 2022
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Mar 18, 2022
@ryparker ryparker added the p1 label Mar 18, 2022
@ryparker
Copy link
Contributor

Hey @konokenj 👋🏻

Thanks for reporting this! I'll let the team know.

@ryparker
Copy link
Contributor

ryparker commented Mar 18, 2022

Looks like this is the case for all languages.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. p1 package/tools Related to AWS CDK Tools or CLI
Projects
None yet
3 participants