Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cli): templates don't include .gitignore #19482

Merged
merged 3 commits into from
Mar 21, 2022
Merged

fix(cli): templates don't include .gitignore #19482

merged 3 commits into from
Mar 21, 2022

Conversation

iliapolo
Copy link
Contributor

@iliapolo iliapolo commented Mar 20, 2022 •
edited
Loading

Fixes #19460

All Submissions:

Adding new Unconventional Dependencies:

  • This PR adds new unconventional dependencies following the process described here

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Mar 20, 2022

@iliapolo iliapolo requested a review from a team March 20, 2022 15:55
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Mar 20, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 20, 2022
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: df92e64
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@rix0rrr rix0rrr merged commit 5ce0983 into master Mar 21, 2022
@rix0rrr rix0rrr deleted the epolon/bundle-doesnt-include-gitignore branch March 21, 2022 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
contribution/core This is a PR that came from AWS. package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

(cli): .gitignore is not generated during cdk init app from v2.14 or later
3 participants
@iliapolo @aws-cdk-automation @rix0rrr