fix(events-targets): cannot set retry policy to 0 retry attempts

[VarunWachaspati]

Currently, it is not possible to set 0 retry attempts for any of the EventBridge targets that support a retry policy as 0 is falsy value and hence the following conditional doesn't evaluate to true -

aws-cdk/packages/@aws-cdk/aws-events-targets/lib/util.ts

Lines 54 to 59 in c607ca5

	retryPolicy: retryAttempts || maxEventAge
	? {
	maximumRetryAttempts: retryAttempts,
	maximumEventAgeInSeconds: maxEventAge?.toSeconds({ integral: true }),
	}
	: undefined,

Changed the conditional logic to allow 0 retry attempts for all supported targets along with unit tests.

fixes #21864

---

All Submissions:

• Have you followed the guidelines in our Contributing guide?

Adding new Unconventional Dependencies:

• This PR adds new unconventional dependencies following the process described here

New Features

• Have you added the new feature to an integration test?
  • Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[gitpod-io]

[TheRealAmazonKendra]

I just set a bad example here and did what I ask people not to do. So, just in case you have a reason to update the branch with a merge, please use @Mergifyio update instead of what I did.

[TheRealAmazonKendra]

This bug is a great find. Thanks for submitting the fix! It looks great and nearly ready to go as is. We'll just need an integration test for this somewhere. Feel free to use an existing one and update it to have retryAttempts = 0.

Additionally, please make sure that your PR title confirms to the conventional commit standard (fix, feat, chore) and that it is written in a style that will reflect correctly in the change log (See Contributing Guide, Pull Requests (https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md#step-4-pull-request)).

Specifically from the guide fix: describe the bug (not the solution) and Title should be lowercase.

Pull request has been modified.

[VarunWachaspati]

Thanks for your feedback. I have updated the PR title to the best of my understanding as per the conventional commit standard. In case it is still not satisfactory, please do let me know.

I have changed the existing lambda integration test to test for the 0 retry attempt case, and ran the integration test successfully on my local machine as well.

yarn integ lambda/integ.events.js
yarn run v1.22.19
$ integ-runner lambda/integ.events.js

Verifying integration test snapshots...

  UNCHANGED  lambda/integ.events 2.449s

Snapshot Results:

Tests:    1 passed, 1 total
✨  Done in 2.91s.

Hope this is sufficient.

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 28af3fa
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).