Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): update csharp & fsharp template to net6.0 #23926

Merged
merged 17 commits into from
Mar 1, 2023
Merged

feat(cli): update csharp & fsharp template to net6.0 #23926

merged 17 commits into from
Mar 1, 2023

Conversation

berviantoleo
Copy link
Contributor

@berviantoleo berviantoleo commented Jan 31, 2023 •
edited by mrgrain

Update the csharp & fsharp templates to net6.0

NET Core 3.1 is EOL, see https://endoflife.date/dotnet

Closes #23921.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Jan 31, 2023

@github-actions github-actions bot added feature-request A feature should be added or improved. p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 31, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team January 31, 2023 11:32
aws-cdk-automation
aws-cdk-automation previously requested changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

@berviantoleo berviantoleo changed the title Update csharp template to net6.0 feat(cli): Update csharp template to net6.0 Jan 31, 2023
@berviantoleo
Copy link
Contributor Author

Anyway, I can't run the integration test. Feel free to abort this change if you do not plan to update the templates.

@TheRealAmazonKendra
Copy link
Contributor

We'll run this through our testing pipeline to run the test, so no worries about that.

@TheRealAmazonKendra
Copy link
Contributor

I think this is a problem of what we install on the image that we're testing from. Can we put this on hold for a day so I can look into that? I don't want you putting in a ton of work trying to fix this on your end if it's settings that aren't in this repo.

@TheRealAmazonKendra
Copy link
Contributor

OK, I found this faster than I thought I would. We use distribution in jsii and it's set to 3.1 here. So, this needs to be updated before we can update it here.

@berviantoleo
Copy link
Contributor Author

OK, I found this faster than I thought I would. We use distribution in jsii and it's set to 3.1 here. So, this needs to be updated before we can update it here.

So, I assume we are not ready to update to net6.0? If you need me to update the jsii too, I'm happy to help.

@TheRealAmazonKendra
Copy link
Contributor

OK, I found this faster than I thought I would. We use distribution in jsii and it's set to 3.1 here. So, this needs to be updated before we can update it here.

So, I assume we are not ready to update to net6.0? If you need me to update the jsii too, I'm happy to help.

As far as I know, if the update gets made in jsii, we're likely safe to do it here. So, if you'd like to submit that PR, please go ahead and do so. If not, I can probably look into it next week.

@berviantoleo berviantoleo mentioned this pull request Feb 12, 2023
Merged
RomainMuller added a commit to aws/jsii that referenced this pull request Feb 17, 2023
@berviantoleo @RomainMuller
feat(dotnet): update TargetFramework to net6.0 (#3957)
ae335ed 
BREAKING CHANGE: The runtime library for .NET & generated .NET bindings will no longer support netcoreapp3.1 after this release. Users are advised to upgrade their apps to use net6.0 or net7.0 instead.

Related: aws/aws-cdk#23926
Related: aws/aws-cdk#23921

Co-authored-by: 🧑🏻‍💻 Romain Marcadier <rmuller@amazon.com>
@aws-cdk-automation
Copy link
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@berviantoleo
Copy link
Contributor Author

As far as I know, if the update gets made in jsii, we're likely safe to do it here. So, if you'd like to submit that PR, please go ahead and do so. If not, I can probably look into it next week.

After that, we need to update the jsii version in here, right?

berviantoleo and others added 5 commits February 22, 2023 14:06
@berviantoleo
Merge branch 'main' into feat/upgrade-csharp-template
d91a924
@aws-cdk-automation @berviantoleo
docs(cfnspec): update CloudFormation documentation (aws#24267)
01785b2
@berviantoleo
chore(ec2): allow opting out of VPN Gateway lookup (aws#24256)
218a7e3 
When using `Vpc.fromLookup()`, a call may be made to determine whether a VPN Gatway is attached. This call can be undesirable, for example when the lookup role does not have permissions to make this call. This adds a flag to allow opting out of VPN Gateways being queried to alleviate this requirement.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@RomainMuller @berviantoleo
chore: use jsii@v4.9-next to compile experimental packages (aws#24271)
c953d42 
This is to help vet that the new release line correctly interoperates with `jsii@1.x` before issuing a stable release.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@berviantoleo
Merge branch 'main' into feat/upgrade-csharp-template
fdefe36
@berviantoleo
Copy link
Contributor Author

Exemption Request

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Feb 22, 2023
@TheRealAmazonKendra
Copy link
Contributor

Running this through our testing pipeline again now that the jsii updates have been made.

@TheRealAmazonKendra TheRealAmazonKendra added pr-linter/exempt-integ-test The PR linter will not require integ test changes pr/needs-cli-test-run This PR needs CLI tests run against it. and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Feb 27, 2023
@aws-cdk-automation aws-cdk-automation dismissed stale reviews from themself February 27, 2023 22:50

✅ Updated pull request passes all PRLinter validations. Dissmissing previous PRLinter review.

@berviantoleo
Copy link
Contributor Author

Running this through our testing pipeline again now that the jsii updates have been made.

Ok. If there are required changes on my side, please let me know.

@TheRealAmazonKendra
Copy link
Contributor

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Feb 28, 2023

update

✅ Branch has been successfully updated

@TheRealAmazonKendra TheRealAmazonKendra mentioned this pull request Mar 1, 2023
Closed
@mrgrain
Copy link
Contributor

mrgrain commented Mar 1, 2023

I run effectively the same change in 1cebe83f-a253-4af2-b4a6-018678ccd5d7

mrgrain
mrgrain approved these changes Mar 1, 2023
View reviewed changes
Copy link
Contributor

@mrgrain mrgrain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one!

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mrgrain mrgrain changed the title feat(cli): Update csharp template to net6.0 feat(cli): update csharp & fsharp template to net6.0 Mar 1, 2023
@github-actions github-actions bot added the effort/small Small work item – less than a day of effort label Mar 1, 2023
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 9a1bc90
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 3bd611d into aws:main Mar 1, 2023
@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

homakk pushed a commit to homakk/aws-cdk that referenced this pull request Mar 28, 2023
@berviantoleo @homakk
feat(cli): update csharp & fsharp template to net6.0 (aws#23926)
c57f4c8 
Update the csharp & fsharp templates to net6.0

NET Core 3.1 is EOL, see https://endoflife.date/dotnet

Closes aws#23921.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@filletofish filletofish mentioned this pull request Jul 2, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrgrain mrgrain mrgrain approved these changes

@aws-cdk-automation aws-cdk-automation aws-cdk-automation left review comments

Assignees
No one assigned
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-cli-test-run This PR needs CLI tests run against it. pr-linter/exempt-integ-test The PR linter will not require integ test changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cdk init: Upgrade from netcoreapp3.1 to net6.0
5 participants
@berviantoleo @TheRealAmazonKendra @aws-cdk-automation @mrgrain @RomainMuller