Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): upgrade dotnet version to 6.0 #24400

Closed
wants to merge 3 commits into from

Conversation

mrgrain
Copy link
Contributor

@mrgrain mrgrain commented Mar 1, 2023

.NET Core 3.1 is EOL, see https://endoflife.date/dotnet

Also fixes a non-compiling test in the Go sample-app.
Fixes the Go integ test not passing.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 1, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team March 1, 2023 16:24
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 1, 2023
@mrgrain mrgrain changed the title chore(cli-integ): fix go init template test chore(cli): upgrade dotnet version to 6.0 Mar 1, 2023
@mrgrain
Copy link
Contributor Author

mrgrain commented Mar 1, 2023

@Mergifyio update

@mergify
Copy link
Contributor

mergify bot commented Mar 1, 2023

update

✅ Branch has been successfully updated

@mrgrain mrgrain marked this pull request as ready for review March 1, 2023 17:17
@mrgrain
Copy link
Contributor Author

mrgrain commented Mar 1, 2023

Test pipeline run 1cebe83f-a253-4af2-b4a6-018678ccd5d7

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 19dd41f
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@TheRealAmazonKendra
Copy link
Contributor

I think we already have an open PR for this. They were just waiting for us to run it though our test pipeline.

@TheRealAmazonKendra
Copy link
Contributor

#23926

@mrgrain
Copy link
Contributor Author

mrgrain commented Mar 1, 2023

Exciting!

@mrgrain mrgrain closed this Mar 1, 2023
@mrgrain mrgrain deleted the mrgrain/fix/init-integ-tests branch July 26, 2023 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. p2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants