fix(codepipeline): x-env ECS deployment lacking support stack-dependency #24053
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…k dependency In the case of a cross-account AND cross-region ECS deployment, a dependency between the support stacks that is necessary is missing. This cannot be fixed globally. Because the resources reference each other bidirectionally (user -> bucket, bucket -> user), the only way to fix this is to do it locally: in the CodePipeline module, where we can have the knowledge that we use generated names and that everything will work out if we deploy the role before the bucket. All CodePipeline Actions must have this fix eventually, but since people may have crazy stack setups in which addition of this dependency may introduce a cyclic dependency (breaking the synth), we're rolling this fix out with limited blast radius. Follow-up in #24050, and suggest a good clean-up in #24051.
rix0rrr
added
the
pr-linter/exempt-integ-test
|
|
comcalvi
reviewed
Feb 8, 2023
Comment on lines
-70
to
-75
| applicationMultipleTargetGroupsFargateService.loadBalancers[0]._enableCrossEnvironment; | ||
| applicationMultipleTargetGroupsFargateService.loadBalancers[1]._enableCrossEnvironment; | ||
|
|
||
| applicationMultipleTargetGroupsFargateService.listeners[0].listenerArn; | ||
| applicationMultipleTargetGroupsFargateService.listeners[1].listenerArn; | ||
|
|
There was a problem hiding this comment.
Aren't these breaking changes?
There was a problem hiding this comment.
nvm, I thought these were snapshot changes but they're not
comcalvi
approved these changes
Feb 9, 2023
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the case of a cross-account AND cross-region ECS deployment, a dependency between the support stacks that is necessary is missing.
This cannot be fixed globally. Because the resources reference each other bidirectionally (user -> bucket, bucket -> user), the only way to fix this is to do it locally: in the CodePipeline module, where we can have the knowledge that we use generated names and that everything will work out if we deploy the role before the bucket.
All CodePipeline Actions must have this fix eventually, but since people may have crazy stack setups in which addition of this dependency may introduce a cyclic dependency (breaking the synth), we're rolling this fix out with limited blast radius.
Follow-up in #24050, and suggest a good clean-up in #24051.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license