Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline): x-env ECS deployment lacking support stack-dependency #24053

Merged
merged 2 commits into from
Feb 10, 2023

Commits on Feb 7, 2023

  1. fix(codepipeline): x-acct/x-region ECS deployment misses support stac…

    …k dependency
    
    In the case of a cross-account AND cross-region ECS deployment, a
    dependency between the support stacks that is necessary is missing.
    
    This cannot be fixed globally. Because the resources reference each
    other bidirectionally (user -> bucket, bucket -> user), the only way to
    fix this is to do it locally: in the CodePipeline module, where we can
    have the knowledge that we use generated names and that everything will
    work out if we deploy the role before the bucket.
    
    All CodePipeline Actions must have this fix eventually, but since
    people may have crazy stack setups in which addition of this dependency
    may introduce a cyclic dependency (breaking the synth), we're rolling
    this fix out with limited blast radius.
    
    Follow-up in #24050, and suggest a good clean-up in #24051.
    rix0rrr committed Feb 7, 2023
    Configuration menu
    Copy the full SHA
    37c1ce4 View commit details
    Browse the repository at this point in the history

Commits on Feb 10, 2023

  1. Configuration menu
    Copy the full SHA
    8b9565a View commit details
    Browse the repository at this point in the history