Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Pool Triggers Missing #2497

Closed
onedotover opened this issue May 7, 2019 · 6 comments · Fixed by #3910
Closed

User Pool Triggers Missing #2497

onedotover opened this issue May 7, 2019 · 6 comments · Fixed by #3910
Assignees
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/aws-cognito Related to Amazon Cognito feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.

Comments

@onedotover
Copy link

Describe the bug
Lambda trigger definitions for "Pre Token Generation" and "User Migration" are missing from the allowed values.

To Reproduce

    const pool = new cognito.UserPool(this, 'UserPool', {
      lambdaTriggers: {
        preTokenGeneration: handler,
      }
    });

Expected behavior
Ability to define preTokenGeneration and userMigration triggers.

Version:
@aws-cdk/aws-cognito@0.31.0

@onedotover onedotover added the bug This issue is a bug. label May 7, 2019
@electrified
Copy link

This is quite an omission, we are facing the same problem too.

Unfortunately it seems that it is missing from CloudFormation: https://forums.aws.amazon.com/thread.jspa?threadID=268907

@RomainMuller
Copy link
Contributor

@electrified is correct - those features are not supported by CloudFormation, and hence cannot be supported by the CDK, unfortunately.

@NGL321 NGL321 added feature-request A feature should be added or improved. @aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/aws-cognito Related to Amazon Cognito closing-soon This issue will automatically close in 4 days unless further comments are made. and removed bug This issue is a bug. labels Jun 20, 2019
@NGL321
Copy link
Contributor

NGL321 commented Jun 20, 2019

This is quite an omission, we are facing the same problem too.

Unfortunately it seems that it is missing from CloudFormation: https://forums.aws.amazon.com/thread.jspa?threadID=268907

@electrified Thanks for linking the forum post. Yes, I have passed this along to the Cloudformation and Cognito groups. Until those are added to cloudformation there is nothing we can do to add that functionality.

Thank you for bringing this back to our attention!
I'm going to close this issue for now. Once those features are added to Cfn, I will reopen this as a feature request.

@NGL321
Copy link
Contributor

NGL321 commented Jul 15, 2019

In an effort to have better visibility of Cfn support gaps, we are going to keep these open, so I am going to reopen this issue.

@NGL321 NGL321 reopened this Jul 15, 2019
@NGL321 NGL321 removed the closing-soon This issue will automatically close in 4 days unless further comments are made. label Jul 15, 2019
@cbeattie-bsm
Copy link

CloudFormation added support for both of these triggers on August 5th.

@eladb eladb self-assigned this Aug 12, 2019
@NGL321 NGL321 added needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. and removed no-cfn-supp labels Aug 23, 2019
vas1468 added a commit to vas1468/aws-cdk that referenced this issue Sep 2, 2019
@mergify mergify bot closed this as completed in #3910 Sep 12, 2019
mergify bot pushed a commit that referenced this issue Sep 12, 2019
* feat(cognito): add PreTokenGeneration lambda trigger support

fixes #2497

* Update to adhere LambdaConfigProperty

* feat(cognito): add UserMigration lambda trigger support

* feat(cognito): add different instances of lambda functions on the user pool test(if api correctly appends triggers)
@Carshy
Copy link

Carshy commented Sep 28, 2019

not well understood

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/aws-cognito Related to Amazon Cognito feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants