Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): support nodejs18.x for CustomResourceProviderRuntime. #25709

Merged
merged 3 commits into from
May 31, 2023

Conversation

Zishanwang1992
Copy link
Contributor

Closes #25665


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented May 24, 2023

@github-actions github-actions bot added beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels May 24, 2023
@aws-cdk-automation aws-cdk-automation requested a review from a team May 24, 2023 01:23
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label May 24, 2023
@vinayak-kukreja
Copy link
Contributor

Hey, thank you for your contribution. This looks good to me.

Getting a second opinion from @corymhall.

@mergify
Copy link
Contributor

mergify bot commented May 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: db87824
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit d99733f into aws:main May 31, 2023
7 checks passed
@mergify
Copy link
Contributor

mergify bot commented May 31, 2023

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@notnonot
Copy link

notnonot commented Jun 1, 2023

Is there a specific date for the release of the new version? @vinayak-kukreja

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-cdk-lib): (CustomResourceProviderRuntime not support NODEJS_18_X)
5 participants