aws-batch-alpha: unable to import FargateComputeEnvironment with from_fargate_compute_environment_arn

[roketworks]

Describe the bug

When importing a fargate compute environment that is created outside of the stack the following error occurs:

jsii.errors.JavaScriptError:
  @jsii/kernel.RuntimeError: TypeError: Cannot read properties of undefined (reading 'vpcId')
      at Kernel._ensureSync (/private/var/folders/01/8c7x7kn954573yk8__rn5d9m0000gn/T/tmpduoq304b/lib/program.js:10369:27)
      at Kernel.sinvoke (/private/var/folders/01/8c7x7kn954573yk8__rn5d9m0000gn/T/tmpduoq304b/lib/program.js:9790:34)
      at KernelHost.processRequest (/private/var/folders/01/8c7x7kn954573yk8__rn5d9m0000gn/T/tmpduoq304b/lib/program.js:11544:36)
      at KernelHost.run (/private/var/folders/01/8c7x7kn954573yk8__rn5d9m0000gn/T/tmpduoq304b/lib/program.js:11504:22)
      at Immediate._onImmediate (/private/var/folders/01/8c7x7kn954573yk8__rn5d9m0000gn/T/tmpduoq304b/lib/program.js:11505:46)
      at process.processImmediate (node:internal/timers:478:21)

Expected Behavior

The resource gets imported and can be referenced

Current Behavior

The error occurs and unable reference resources

Reproduction Steps

• Create 2 batch compute environments, one fargate and one ECS.

# Works
ecs_compute_arn = 'arn:aws:batch:us-east-1:xxx:compute-environment/ecs-compute'
ecs_compute_env = batch.ManagedEc2EcsComputeEnvironment.from_managed_ec2_ecs_compute_environment_arn(
    self, 'FargateComputeEnv', managed_ec2_ecs_compute_environment_arn=ecs_compute_arn
)
queue = batch.JobQueue(self, 'Queue', job_queue_name='queue')
queue.add_compute_environment(ecs_compute_env, 1)

# Error occurs
fargate_compute_arn = 'arn:aws:batch:us-east-1:xxx:compute-environment/fargate-compute'
fargate_compute_env = batch.FargateComputeEnvironment.from_fargate_compute_environment_arn(
    self, 'FargateComputeEnv', fargate_compute_environment_arn=fargate_compute_arn
)
queue = batch.JobQueue(self, 'Queue', job_queue_name='queue')
queue.add_compute_environment(fargate_compute_env, 1)

Possible Solution

No response

Additional Information/Context

No response

CDK CLI Version

2.81.0

Framework Version

2.83.1

Node.js Version

v19.8.1

OS

Mac OS 12.6

Language

Python

Language Version

3.11

Other information

No response

[pahud]

Looks like this requires vpc here

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/managed-compute-environment.ts

Line 223 in 104bf32

vpc: props.vpc,

But fromFargateComputeEnvironmentArn is not having any vpc info

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/managed-compute-environment.ts

Line 1078 in 104bf32

vpc: undefined as any,

[peterwoodworth]

Thanks for reporting this, I'm finding the same behavior.

It's because the import class extends ManagedComputeEnvironmentBase, which requires an IVpc prop. When creating the import class and instance of it, fromFargateComputeEnvironmentArn() passes in undefined as the IVpc.

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/managed-compute-environment.ts

Lines 1071 to 1079 in 104bf32

	class Import extends ManagedComputeEnvironmentBase implements IFargateComputeEnvironment {
	public readonly computeEnvironmentArn = fargateComputeEnvironmentArn;
	public readonly computeEnvironmentName = computeEnvironmentName;
	public readonly enabled = true;
	}
	return new Import(scope, id, {
	vpc: undefined as any,
	});

However, since the import class extends ManagedComputeEnvironmentBase, it will attempt to reference the IVpc when creating the security groups.

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/managed-compute-environment.ts

Lines 221 to 225 in 104bf32

	this.securityGroups = props.securityGroups ?? [
	new ec2.SecurityGroup(this, 'SecurityGroup', {
	vpc: props.vpc,
	}),
	];

Should probably extend Resource just like ManagedEc2EcsComputeEnvironment does

aws-cdk/packages/@aws-cdk/aws-batch-alpha/lib/managed-compute-environment.ts

Line 589 in 104bf32

class Import extends Resource implements IManagedEc2EcsComputeEnvironment {

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.