Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Specify subnets for Classic Load Balancer #2833

Closed
ScOut3R opened this issue Jun 12, 2019 · 1 comment
Closed

Specify subnets for Classic Load Balancer #2833

ScOut3R opened this issue Jun 12, 2019 · 1 comment
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ScOut3R
Copy link
Contributor

ScOut3R commented Jun 12, 2019

The construct fails if the VPC defines multiple private subnets in an availability zone which is a likely use-case.

I suggest introducing an optional property to pass in the subnets we want use for the load balancer.

WIP - PR will follow
@ScOut3R ScOut3R added the feature-request A feature should be added or improved. label Jun 12, 2019
ScOut3R added a commit to ScOut3R/aws-cdk that referenced this issue Jun 12, 2019
@ScOut3R
feat(aws-elasticloadbalancing): specify subnets for Classic Load Bala…
420b3cb 
…ncer (aws#2833)

Solves the problem of having multiple private subnets in one availability zone.

WIP - missing test(s)
@NGL321 NGL321 added the needs-triage This issue or PR still needs to be triaged. label Jun 17, 2019
ScOut3R added a commit to ScOut3R/aws-cdk that referenced this issue Jul 24, 2019
@ScOut3R
feat(elasticloadbalancing): add subnet selection (aws#2833)
f317a9e 
Add the ability to specify the subnets the classic load balancer is
deployed to.

closes (aws#2833)
@ScOut3R ScOut3R mentioned this issue Jul 24, 2019
Merged
ScOut3R added a commit to ScOut3R/aws-cdk that referenced this issue Aug 8, 2019
@ScOut3R
feat(elasticloadbalancing): add subnet selection (aws#2833)
1d9d8ef 
Update subnetSelection property to follow API standards

closes(aws#2833)
mergify bot pushed a commit that referenced this issue Aug 8, 2019
@ScOut3R @mergify
feat(elasticloadbalancing): add subnet selection (#2833) (#3415)
14e4bc9 
* feat(elasticloadbalancing): add subnet selection (#2833)

Add the ability to specify the subnets the classic load balancer is
deployed to.

closes (#2833)

* feat(elasticloadbalancing): add subnet selection (#2833)

Update subnetSelection property to follow API standards

closes(#2833)
@ScOut3R
Copy link
Contributor Author

ScOut3R commented Aug 8, 2019

This was closed by #3415

@ScOut3R ScOut3R closed this as completed Aug 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ScOut3R @NGL321