Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

init templates: add cdk.out/ and .env/ (python only) to .gitignore #2842

Closed
dhx-mike-palandra opened this issue Jun 12, 2019 · 2 comments · Fixed by #3863
Closed

init templates: add cdk.out/ and .env/ (python only) to .gitignore #2842

dhx-mike-palandra opened this issue Jun 12, 2019 · 2 comments · Fixed by #3863
Assignees
@shivlaks
Labels
feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md package/tools Related to AWS CDK Tools or CLI

Comments

@dhx-mike-palandra
Copy link

$ cdk --version
0.34.0 (build 523807c)
@dhx-mike-palandra dhx-mike-palandra added the feature-request A feature should be added or improved. label Jun 12, 2019
@NGL321 NGL321 added the needs-triage This issue or PR still needs to be triaged. label Jun 17, 2019
@bgdnlp
Copy link

bgdnlp commented Jun 18, 2019

For Python, I'd set:

cdk.out/

__pycache__/
*.py[cod]
*$py.class

.env
.venv
env/
venv/
ENV/
env.bak/
venv.bak/

Maybe vi backup and swap files, too.

There is a more complete .gitignore from Github, but it looks too much.

@shivlaks shivlaks added package/tools Related to AWS CDK Tools or CLI good first issue Related to contributions. See CONTRIBUTING.md and removed needs-triage This issue or PR still needs to be triaged. labels Aug 29, 2019
@shivlaks
Copy link
Contributor

@bgdnlp that seems like a reasonable starting point and I agree the example you linked does feel like overkill.

shivlaks added a commit that referenced this issue Aug 29, 2019
@shivlaks
fix(cli): fix .gitignore for Python init templates to include environ…
8d887f5 
…ments and CDK context/staging files

Fixes #2842
@shivlaks shivlaks mentioned this issue Aug 29, 2019
Merged
@mergify mergify bot closed this as completed in #3863 Aug 29, 2019
mergify bot pushed a commit that referenced this issue Aug 29, 2019
@shivlaks @mergify
fix(init-templates): fix to include environments and CDK files to .gi…
e4f9677 
…tignore for Python templates (#3863)

* fix(cli): fix .gitignore for Python init templates to include environments and CDK context/staging files

Fixes #2842

* remove cdk.context.json from .gitignore as we want subsequent synth commands to return same result
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shivlaks shivlaks

Labels
feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md package/tools Related to AWS CDK Tools or CLI
Projects
None yet
Milestone
No milestone
4 participants
@bgdnlp @NGL321 @shivlaks @dhx-mike-palandra