-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cloudformation-diff: Hidden dependency on aws-sdk #28679
Closed
frankpengau opened this issue
Jan 12, 2024
· 2 comments
· Fixed by #28680 or #28768 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Closed
cloudformation-diff: Hidden dependency on aws-sdk #28679
frankpengau opened this issue
Jan 12, 2024
· 2 comments
· Fixed by #28680 or #28768 · May be fixed by stack-spot/app-handler-functions-template#2, stack-spot/eks-env-ts-template#2 or stack-spot/web-react-deploy#4
Labels
@aws-cdk/cloudformation-diff
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p1
Comments
Thank you for the report. We will review the implementation in your PR. |
mergify bot
pushed a commit
that referenced
this issue
Jan 16, 2024
Missing dependency when exporting `@aws-cdk/cloudformation-diff` in custom AWS Construct Library. Closes #28679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
This was referenced Feb 10, 2024
mergify bot
pushed a commit
that referenced
this issue
Mar 16, 2024
…get CFN types resolved in exports (#28768) Issue still persists after #28680. ``` node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations. 1 import type { CloudFormation } from 'aws-sdk'; ~~~~~~~~~ Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1 ``` Types are still required as a direct dependency in package.json. Closes #28679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
ahammond
pushed a commit
to ahammond/aws-cdk
that referenced
this issue
Mar 26, 2024
…get CFN types resolved in exports (aws#28768) Issue still persists after aws#28680. ``` node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1:37 - error TS2307: Cannot find module 'aws-sdk' or its corresponding type declarations. 1 import type { CloudFormation } from 'aws-sdk'; ~~~~~~~~~ Found 1 error in node_modules/@aws-cdk/cloudformation-diff/lib/diff-template.d.ts:1 ``` Types are still required as a direct dependency in package.json. Closes aws#28679 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/cloudformation-diff
bug
This issue is a bug.
effort/medium
Medium work item – several days of effort
p1
Describe the bug
We have a custom aws-cdk consruct library that exports cloudformation-diff.
Since
@aws-cdk/cloudformation-diff
for version2.119.0
, it is throwing the following error:We believe the error is coming from changes in this PR: #28336
Specifically in
packages/@aws-cdk/cloudformation-diff/lib/diff-template.ts
, the following change:I have a sample repo to reproduce the exact issue: https://github.com/frankpengau/cdk-lib-cfn-diff-issue-20240112
Expected Behavior
It should not have a missing dependency.
Current Behavior
It currently has an indirect dependency on
aws-sdk
causing our construct library to have a transitive dependency onaws-sdk
. If it is indeed a dependency, it should be added in as such, instead of being only a devdependency.Reproduction Steps
cdk init lib --language typescript
@aws-cdk/cloudformation-diff
for version2.119.0
export * as cfndiff from @aws-cdk/cloudformation-diff
tsc
Possible Solution
Explicit dependency on
aws-sdk
, so that it shows up in thepackage-lock.json
file and installs it as necessary for@aws-cdk/cloudformation-diff
to work.Additional Information/Context
No response
CDK CLI Version
2.114.1
Framework Version
No response
Node.js Version
18.13.0
OS
macOS
Language
TypeScript
Language Version
TypeScript (5.2.2)
Other information
No response
The text was updated successfully, but these errors were encountered: