fix(appconfig): prefix names with resource name #28742
Conversation
github-actions
bot
added
the
valued-contributor
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
kaizencc
added
the
pr-linter/exempt-integ-test
There was a problem hiding this comment.
Nice!
One overall thing unrelated to this PR (but I know you wrote the module too @chenjane-dev). Everywhere you have a || logical OR you really want a ?? nullish coalescer. The subtle difference is this:
'' ?? 'default'; // evaluates to '', because it takes the right-hand side only if the left-hand side is `null` or `undefined`
'' || 'default'; // evaluates to 'default', because it takes the right-hand side if the left-hand side is falsyNow you can debate the merits for what specifying an empty string truly entails, but in some rare cases, users actually WANT an '' (in the general sense. i'm not saying that this is a valid input for name). On the CDK side we try haphazardly to standardize on ?? for this reason, though we do not do a good job enforcing.
Not a problem for now, and I know you just want to get this in. But food for thought.
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…28671) Auditing awslint errors. Reasons for keeping current list of exemptions: * "no-unused-type:@aws-cdk/aws-appconfig-alpha.PredefinedDeploymentStrategyId" - will be fixed in a separate PR. * "props-physical-name:@aws-cdk/aws-appconfig-alpha.ApplicationProps" "props-physical-name:@aws-cdk/aws-appconfig-alpha.DeploymentStrategyProps" "props-physical-name:@aws-cdk/aws-appconfig-alpha.EnvironmentProps" "props-physical-name:@aws-cdk/aws-appconfig-alpha.ExtensionProps" - will be fixed in a separate PR. * "events-method-signature" - exempting because appconfig handles their events without cloudwatch events * "events-generic" - exempting because appconfig handles their events without cloudwatch events Closes #27894 alongside #28742 and #28743 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Linter rules caught that CDK standardizes resource name prop as
[resource]Name. Previously this module only usednamefor the prop.Follow up from #28671.
BREAKING CHANGE:
ApplicationProps.namerenamed toApplicationProps.applicationNameEnvironmentProps.namerenamed toEnvironmentProps.environmentNameDeploymentStrategyProps.namerenamed toDeploymentStrategyProps.deploymentStrategyNameExtensionProps.namerenamed toExtensionProps.extensionNameBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license