-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RDS: support passing PreferredMaintenanceWindow to Cluster's writer and reader instances #29687
RDS: support passing PreferredMaintenanceWindow to Cluster's writer and reader instances #29687
Comments
Thanks @Konosh93 for reporting this and submitting a PR ! |
…ps (#29686) ### Issue #29687 Closes ##29687 ### Reason for this change Since `instanceProps` is deprecated it is better to allow setting `PreferredMaintenanceWindow` using writer and readers props. ### Description of changes Added optional preferredMaintenanceWindow field to ClusterInstanceOptions and added a unit test. ### Description of how you validated changes - Add a single unit test ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Comments on closed issues and PRs are hard for our team to see. If you need help, please open a new issue that references this one. |
Describe the bug
Related:
When creating a DatabaseCluster it should be possible to specify PreferredMaintenanceWindow property for the database instances as per https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-rds-dbinstance.html#cfn-rds-dbinstance-preferredmaintenancewindow
Expected Behavior
Should be able specify the writer and readers PreferredMaintenanceWindow prop without using the deprecated instanceProps property.
Expected style:
Current Behavior
Can specify the PreferredMaintenanceWindow prop only through
instanceProps
:Reproduction Steps
Trying adding
preferredMaintenanceWindow
to writer or readers props:Possible Solution
feat(rds): allow specifying PreferredMaintenanceWindow in RDS cluster instances using the new api
Additional Information/Context
No response
CDK CLI Version
1.158.0
Framework Version
No response
Node.js Version
v18.17.1
OS
Linux
Language
TypeScript
Language Version
5.1.6
Other information
No response
The text was updated successfully, but these errors were encountered: