Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-events-targets EcsTask Only allows one security group to be added #3312

Closed
1 of 5 tasks
phcyso opened this issue Jul 16, 2019 · 1 comment · Fixed by #7857
Closed
1 of 5 tasks

aws-events-targets EcsTask Only allows one security group to be added #3312

phcyso opened this issue Jul 16, 2019 · 1 comment · Fixed by #7857
Assignees
@efekarakus @SoManyHs @piradeepk
Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@phcyso
Copy link

phcyso commented Jul 16, 2019 •
edited by NGL321

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.

  • What is the current behavior?
    When using AwsVpc mode for scheduled fargate tasks the optional securityGroup prop on EcsTask only allows for passing one security group through.

It gets cast to an array within the custom resource:
https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-events-targets/lib/ecs-task.ts#L141

  • What is the expected behavior (or behavior of feature suggested)?
    It should allow a array of security groups to be passed through.

  • What is the motivation / use case for changing the behavior or adding this feature?
    To allow multiple source security groups to be added to the running scheduled task

  • Please tell us about your environment:

    • CDK CLI Version: 1.0.0
    • Module Version:1.0.0
    • OS: all
    • Language: typescript

  • Other information
    Unless there are further limitation within the NetworkConfiguration & awsvpcConfiguration custom resources this should just be able to be changed to an array of Security groups
@phcyso phcyso added the needs-triage This issue or PR still needs to be triaged. label Jul 16, 2019
@NGL321 NGL321 added @aws-cdk/aws-ecs Related to Amazon Elastic Container feature-request A feature should be added or improved. and removed needs-triage This issue or PR still needs to be triaged. labels Oct 10, 2019
@NGL321 NGL321 assigned SoManyHs and piradeepk and unassigned eladb Oct 10, 2019
@piradeepk piradeepk added the @aws-cdk/aws-events Related to CloudWatch Events label Nov 11, 2019
@MrArnoldPalmer MrArnoldPalmer added the effort/medium Medium work item – several days of effort label May 4, 2020
@MrArnoldPalmer MrArnoldPalmer mentioned this issue May 4, 2020
Closed
1 task
@efekarakus efekarakus self-assigned this May 6, 2020
efekarakus added a commit to efekarakus/aws-cdk that referenced this issue May 8, 2020
@efekarakus
feat(aws-events-targets): support multiple security groups for an ECS…
e1b03d3 
… task

Resolves aws#3312
@efekarakus efekarakus mentioned this issue May 8, 2020
Merged
@efekarakus
Copy link
Contributor

Hi @phcyso 👋

PR #7857 adds a new property securityGroups and deprecates the existing securityGroup to support the request!

@SomayaB SomayaB added the in-progress This issue is being actively worked on. label May 11, 2020
@mergify mergify bot closed this as completed in #7857 May 13, 2020
mergify bot added a commit that referenced this issue May 13, 2020
@efekarakus @mergify
feat(events-targets): support multiple security groups for an ECS task (
c6504e6 
#7857)

* feat(aws-events-targets): support multiple security groups for an ECS task

Resolves #3312

* chore: expose generated security group in securityGroup field

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
karupanerura pushed a commit to karupanerura/aws-cdk that referenced this issue May 22, 2020
@efekarakus @mergify @karupanerura
feat(events-targets): support multiple security groups for an ECS task (
6fd2abe 
aws#7857)

* feat(aws-events-targets): support multiple security groups for an ECS task

Resolves aws#3312

* chore: expose generated security group in securityGroup field

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@efekarakus efekarakus

@SoManyHs SoManyHs

@piradeepk piradeepk

Labels
@aws-cdk/aws-ecs Related to Amazon Elastic Container @aws-cdk/aws-events Related to CloudWatch Events effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(events-targets): support multiple security groups for an ECS task efekarakus/aws-cdk
9 participants
@eladb @efekarakus @phcyso @uttarasridhar @NGL321 @MrArnoldPalmer @SomayaB @SoManyHs @piradeepk