Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

User does not implement IUser #3490

Closed
1 of 5 tasks
kgregory-chariot opened this issue Jul 31, 2019 · 0 comments · Fixed by #3738
Closed
1 of 5 tasks

User does not implement IUser #3490

kgregory-chariot opened this issue Jul 31, 2019 · 0 comments · Fixed by #3738
Assignees
@rix0rrr
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management bug This issue is a bug.

Comments

@kgregory-chariot
Copy link

  • I'm submitting a ...

    • 🪲 bug report
    • 🚀 feature request (I would argue that it's actually a bug)
    • 📚 construct library gap
    • ☎️ security issue or vulnerability => Please see policy
    • ❓ support request => Please see note at the top of this template.

  • What is the current behavior?

The class User and the interface IUser separately inherit from IIdentity and define the properties userName and addToGroup (source).

This means that you can't take a User that you created and pass it to Group.addUser()

  • What is the expected behavior (or behavior of feature suggested)?

You should be able to take a User object and add it to a group (you can go the other way, because Group implements IGroup).

  • What is the motivation / use case for changing the behavior or adding this feature?

Being able to write a CDK script that adds users to groups.

  • Please tell us about your environment:

    • CDK CLI Version: 1.1.0 (build 1a11e96)
    • Module Version: @aws-cdk/aws-iam 1.2.0
    • OS: all
    • Language: TypeScript

  • Other information (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. associated pull-request, stackoverflow, gitter, etc)
@kgregory-chariot kgregory-chariot added the needs-triage This issue or PR still needs to be triaged. label Jul 31, 2019
@eladb eladb added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Aug 13, 2019
@eladb eladb added bug This issue is a bug. and removed needs-triage This issue or PR still needs to be triaged. labels Aug 13, 2019
rix0rrr added a commit that referenced this issue Aug 21, 2019
@rix0rrr
fix(iam): make User implement IUser
16f8bbb 
Languages using nominal typing (Java, C#) require this annotation
to be able to pass a User object where an IUser is expected.

Fixes #3490.
@rix0rrr rix0rrr mentioned this issue Aug 21, 2019
Merged
@mergify mergify bot closed this as completed in #3738 Aug 22, 2019
mergify bot pushed a commit that referenced this issue Aug 22, 2019
@rix0rrr @mergify
fix(iam): make User implement IUser (#3738)
05e13f3 
* fix(iam): make User implement IUser

Languages using nominal typing (Java, C#) require this annotation
to be able to pass a User object where an IUser is expected.

Fixes #3490.

* Fix linter errors
@seawatts seawatts mentioned this issue Jan 14, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(iam): make User implement IUser aws/aws-cdk
3 participants
@rix0rrr @eladb @kgregory-chariot