Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cognito): add PreTokenGeneration lambda trigger support #3910

Merged
merged 9 commits into from
Sep 12, 2019
Merged

feat(cognito): add PreTokenGeneration lambda trigger support #3910

merged 9 commits into from
Sep 12, 2019

Conversation

vas1468
Copy link
Contributor

@vas1468 vas1468 commented Sep 2, 2019

fixes #2497

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2019

Pull Request Checklist

  • Testing
  • Unit test added (prefer to add a new test rather than modify existing tests)
  • CLI change? Re-run/add CLI integration tests
  • Documentation
  • Inline docs: make sure all public APIs are documented (copy & paste from official AWS docs)
  • README: update module README
  • Design: for significant features, follow the design process
  • Title uses the format type(scope): text
  • Type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • Scope: name of the module without the aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • Style: use all lower-case, do not end with a period
  • Description
  • Rationale: describe rationale of change and approach taken
  • Issues: Indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
  • Sensitive Modules (requires 2 PR approvers)
  • IAM document library (in @aws-cdk/aws-iam)
  • EC2 security groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (if not based on official documentation with a reference)

@mergify
Copy link
Contributor

mergify bot commented Sep 2, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

@mergify
Copy link
Contributor

mergify bot commented Sep 4, 2019

Codebuild (Continuous Integration) build failed for current commits. Please check log and resolve before PR is merged.

nija-at
nija-at previously requested changes Sep 10, 2019
View reviewed changes
Copy link
Contributor

@nija-at nija-at left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the pull request. Apologies for the delay in getting to this.

Could you also similarly include the UserMigration trigger?

@mergify mergify bot dismissed nija-at’s stale review September 10, 2019 19:46

Pull request has been modified.

nija-at
nija-at previously requested changes Sep 11, 2019
View reviewed changes
packages/@aws-cdk/aws-cognito/test/test.user-pool.ts Outdated Show resolved Hide resolved
@vas1468
feat(cognito): add different instances of lambda functions on the use…
c5d9afc 
…r pool test(if api correctly appends triggers)
@mergify mergify bot dismissed nija-at’s stale review September 11, 2019 17:19

Pull request has been modified.

nija-at
nija-at approved these changes Sep 12, 2019
View reviewed changes
packages/@aws-cdk/aws-cognito/test/test.user-pool.ts
@@ -53,34 +53,93 @@ export = {
'on* API correctly appends triggers'(test: Test) {
// GIVEN
const stack = new cdk.Stack();
const fn = new lambda.Function(stack, 'MyLambda', {

const createAuthChallengeLambdaFn = new lambda.Function(stack, 'createAuthChallengeLambda', {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would've been cleaner to refactor the new lambda.Function(...) into a separate function to reduce code repeat.

Approving nevertheless.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can open an issue regarding cognition tests and assign it to me. :) We can have a discussion there of what is missing and how we can improve those tests.

@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2019

Thank you for contributing! Your pull request is now being automatically merged.

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Sep 12, 2019

Thank you for contributing! Your pull request is now being automatically merged.

@mergify mergify bot merged commit e9f46da into aws:master Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nija-at nija-at nija-at approved these changes

Assignees

@nija-at nija-at

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

User Pool Triggers Missing
2 participants
@vas1468 @nija-at