feat(aws-codebuild): allow github sourceversion branch

[knorms101]

Addresses issue #5777.

Allows users to specify which GitHub branch a CodeBuild should use as its Source Version. Currently the branch always defaults to 'master', but users may want to test features on other branches

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: FAILED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[skinny85]

Thanks for the contribution @knorms101 , it's great! I have a few small comments.

From looking at the docs of this feature in http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-sourceversion , I see this also works for CodeCommit, BitBucket and S3. Do you have time to add those as well? (S3 probably should be called version instead of branch).

Thanks!

[knorms101]

Thanks for the contribution @knorms101 , it's great! I have a few small comments.

From looking at the docs of this feature in http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-sourceversion , I see this also works for CodeCommit, BitBucket and S3. Do you have time to add those as well? (S3 probably should be called version instead of branch).

Thanks!

Thanks for the feedback, @skinny85! I agree that it would be great to include this option for the other CodeBuild sources too. I'll work on adding that next week.

[skinny85]

Thanks for the contribution @knorms101 , it's great! I have a few small comments.
From looking at the docs of this feature in http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-sourceversion , I see this also works for CodeCommit, BitBucket and S3. Do you have time to add those as well? (S3 probably should be called version instead of branch).
Thanks!

Thanks for the feedback, @skinny85! I agree that it would be great to include this option for the other CodeBuild sources too. I'll work on adding that next week.

Awesome, thanks so much for taking the time to work on this! ❤️

Pull request has been modified.

[knorms101]

Thanks for the contribution @knorms101 , it's great! I have a few small comments.
From looking at the docs of this feature in http://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-codebuild-project.html#cfn-codebuild-project-sourceversion , I see this also works for CodeCommit, BitBucket and S3. Do you have time to add those as well? (S3 probably should be called version instead of branch).
Thanks!

Thanks for the feedback, @skinny85! I agree that it would be great to include this option for the other CodeBuild sources too. I'll work on adding that next week.

Awesome, thanks so much for taking the time to work on this! ❤️

Hi @skinny85 I finally had a chance to continue working on this. I added the optional sourceVersion property to all the other CodeBuild source options. I also added the optional secondarySourceVersions property.

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[skinny85]

Thanks for the contribution @knorms101 !

We're getting closer, but there are a few things that need changing still.

Let me know what you think of the name branchOrRef for the Git-based sources!

Pull request has been modified.

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[skinny85]

This is fantastic @knorms101 ! If you could get rid of a tiny piece of duplication, it will be perfect 😃

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[skinny85]

Thanks for the contribution @knorms101 !

[mergify]

Thank you for contributing! Your pull request is now being automatically merged.

[aws-cdk-automation]

AWS CodeBuild CI Report

• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[mergify]

Thank you for contributing! Your pull request is now being automatically merged.