Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(events-targets): support multiple security groups for an ECS task #7857

Merged
merged 4 commits into from
May 13, 2020
Merged

feat(events-targets): support multiple security groups for an ECS task #7857

merged 4 commits into from
May 13, 2020

Conversation

efekarakus
Copy link
Contributor

@efekarakus efekarakus commented May 8, 2020 •
edited by piradeepk

Commit Message

feat(events-targets): support multiple security groups for an ECS task

Resolves #3312

End Commit Message

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@efekarakus efekarakus mentioned this pull request May 8, 2020
Closed
5 tasks
SoManyHs
SoManyHs reviewed May 8, 2020
View reviewed changes
Copy link
Contributor

@SoManyHs SoManyHs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one small nit.

packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts Show resolved Hide resolved
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: e1b03d3
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

piradeepk
piradeepk previously requested changes May 8, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! We should maintain any publicly accessible properties (and the logic which sets their values).

packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts Outdated Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts Show resolved Hide resolved
packages/@aws-cdk/aws-events-targets/lib/ecs-task.ts
Comment on lines -71 to -72
const securityGroup = props.securityGroup || this.taskDefinition.node.tryFindChild('SecurityGroup') as ec2.ISecurityGroup;
this.securityGroup = securityGroup || new ec2.SecurityGroup(this.taskDefinition, 'SecurityGroup', { vpc: this.props.cluster.vpc });
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should maintain this logic (maybe add a comment that we should remove it when deprecated properties are removed.

@piradeepk piradeepk added the pr-linter/exempt-readme The PR linter will not require README changes label May 8, 2020
@piradeepk piradeepk changed the title feat(aws-events-targets): support multiple security groups for an ECS task feat(events-targets): support multiple security groups for an ECS task May 8, 2020
@mergify mergify bot dismissed piradeepk’s stale review May 8, 2020 19:10

Pull request has been modified.

piradeepk
piradeepk approved these changes May 8, 2020
View reviewed changes
Copy link
Contributor

@piradeepk piradeepk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ship it! 💯

@piradeepk piradeepk added the pr/do-not-merge This PR should not be merged at this time. label May 8, 2020
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: cdeba19
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@SomayaB SomayaB assigned rix0rrr and uttarasridhar and unassigned rix0rrr May 11, 2020
@piradeepk piradeepk removed the pr/do-not-merge This PR should not be merged at this time. label May 12, 2020
@mergify
Copy link
Contributor

mergify bot commented May 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 5cc5e9c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a65e1b0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented May 13, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit c6504e6 into aws:master May 13, 2020
karupanerura pushed a commit to karupanerura/aws-cdk that referenced this pull request May 22, 2020
@efekarakus @mergify @karupanerura
feat(events-targets): support multiple security groups for an ECS task (
6fd2abe 
aws#7857)

* feat(aws-events-targets): support multiple security groups for an ECS task

Resolves aws#3312

* chore: expose generated security group in securityGroup field

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
@efekarakus efekarakus deleted the efekarakus/issues/3312 branch August 27, 2023 03:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SoManyHs SoManyHs SoManyHs left review comments

@MrArnoldPalmer MrArnoldPalmer MrArnoldPalmer approved these changes

@piradeepk piradeepk piradeepk approved these changes

Assignees

@uttarasridhar uttarasridhar

Labels
@aws-cdk/aws-events-targets pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

aws-events-targets EcsTask Only allows one security group to be added
7 participants
@efekarakus @aws-cdk-automation @MrArnoldPalmer @SoManyHs @piradeepk @rix0rrr @uttarasridhar