Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cloudfront): Escape hatch support for Distribution #9648

Merged
merged 2 commits into from
Aug 12, 2020

Conversation

njlynch
Copy link
Contributor

@njlynch njlynch commented Aug 12, 2020

Changed the ID for the CfnDistribution to support escape hatches
(dist.node.defaultChild).

fixes #9620

BREAKING CHANGE: (cloudfront) Changed IDs for Distributions (will cause resource replacement).


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Changed the ID for the CfnDistribution to support escape hatches
(`dist.node.defaultChild`).

fixes #9620

BREAKING CHANGE: (cloudfront) Changed IDs for Distributions
@njlynch njlynch requested a review from skinny85 August 12, 2020 17:24
@njlynch njlynch self-assigned this Aug 12, 2020
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Aug 12, 2020
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 8b3ff87
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 12, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cc229c2 into master Aug 12, 2020
@mergify mergify bot deleted the njlynch/cf-escape-hatches branch August 12, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cloudfront] New Distribution object doesn't support escape hatches
3 participants