Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(elbv2): NLB Target Group does not inherit protocol (#9331) #9651

Merged
merged 3 commits into from Aug 18, 2020
Merged

fix(elbv2): NLB Target Group does not inherit protocol (#9331) #9651

merged 3 commits into from Aug 18, 2020

Conversation

hoegertn
Copy link
Contributor

fixes #9331

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@rix0rrr rix0rrr changed the title fix(elbv2): target group inherits protocol for NLBs (#9331) fix(elbv2): NLB Target Group does not inherit protocol (#9331) Aug 17, 2020
rix0rrr
rix0rrr previously approved these changes Aug 17, 2020
View reviewed changes
@mergify
Copy link
Contributor

mergify bot commented Aug 17, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@hoegertn
Copy link
Contributor Author

@rix0rrr I updated the branch. Please reapprove. Auto-update does not seem to work for orga forks

@mergify mergify bot dismissed rix0rrr’s stale review August 17, 2020 09:55

Pull request has been modified.

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: a6f5d72
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 171ab59 into aws:master Aug 18, 2020
@hoegertn hoegertn deleted the nlb-proto branch August 18, 2020 09:02
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this pull request Aug 19, 2020
@hoegertn @misterjoshua
fix(elbv2): NLB Target Group does not inherit protocol (aws#9331) (aw…
ece1858 
…s#9651)

fixes aws#9331 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@sgvandijk sgvandijk mentioned this pull request Aug 28, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rix0rrr rix0rrr rix0rrr approved these changes

Assignees

@rix0rrr rix0rrr

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[elasticloadbalancingv2] NetworkTargeGroup should inherit protocol from listener
3 participants
@hoegertn @aws-cdk-automation @rix0rrr