Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[codepipeline-actions] Service Catalog Integration sends improper format for file path #9767

Closed
paveljos opened this issue Aug 17, 2020 · 1 comment · Fixed by #9773
Closed
Assignees
Labels
@aws-cdk/aws-codepipeline-actions bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@paveljos
Copy link
Contributor

codepipeline-action's integrtion with Service Catalog sends an improperly formatted file path when referencing an artifact.

Reproduction Steps

{
          stageName: 'ServiceCatalogDeploy',
          actions: [
            new codepipeline_actions.ServiceCatalogDeployAction({
              actionName: 'TestingMyCode',
              templatePath: cdkBuildOutput.atPath("LambdaStack.template.json"),
              productVersionName: "Version - 1",
              productVersionDescription: "This is a version from the pipeline with a new description.",
              productId: "prod-XXXXXXXX",
            }),
          ],
        },

What did you expect to happen?

ServiceCatalog should be able to read the templatePath passed to it in reference to the Artifact.

What actually happened?

The TemplateFilePath is incorrectly generated as CdkBuidOutput::LambdaStack.template.json vs. LambdaStack.template.json

Environment

  • **CLI Version : 1.59
  • **Framework Version: 1.59
  • **Node.js Version: 14.7.0
  • **OS : macOS
  • Language (Version): all

Other

Proposed solution:

this.templatePath = props.templatePath.location;

changed to this.templatePath = props.templatePath.fileName;


This is 🐛 Bug Report

@paveljos paveljos added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2020
@skinny85
Copy link
Contributor

skinny85 commented Aug 17, 2020

Thanks for the issue @paveljos . Any chance of getting a quick PR to fix the problem? Seems like you already know what needs to be changed 🙂

@skinny85 skinny85 added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Aug 17, 2020
@mergify mergify bot closed this as completed in #9773 Aug 18, 2020
mergify bot pushed a commit that referenced this issue Aug 18, 2020
…th (#9773)

Artifact path was incorrectly set to use the artifact location instead of the filename.

Fixes #9767

---

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this issue Aug 19, 2020
…th (aws#9773)

Artifact path was incorrectly set to use the artifact location instead of the filename.

Fixes aws#9767

---

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline-actions bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants