Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(codepipeline): Service Catalog action generated incorrect file path #9773

Merged
merged 20 commits into from
Aug 18, 2020

Conversation

paveljos
Copy link
Contributor

@paveljos paveljos commented Aug 17, 2020

Artifact path was incorrectly set to use the artifact location instead of the filename.

Fixes #9767


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@paveljos paveljos changed the title fix(codepipeline-actions): Service Catalog Integration sends improper format for file path #9767 fix(codepipeline-actions): Service Catalog Integration sends improper format for file path. Fixes #9767 Aug 17, 2020
@skinny85 skinny85 changed the title fix(codepipeline-actions): Service Catalog Integration sends improper format for file path. Fixes #9767 fix(codepipeline): Service Catalog action generated incorrect file path Aug 17, 2020
@skinny85 skinny85 self-assigned this Aug 17, 2020
Copy link
Contributor

@skinny85 skinny85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @paveljos !

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Contributor

mergify bot commented Aug 18, 2020

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject6AEA49D1-qxepHUsryhcu
  • Commit ID: 60b087d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 286ff50 into aws:master Aug 18, 2020
misterjoshua pushed a commit to misterjoshua/aws-cdk that referenced this pull request Aug 19, 2020
…th (aws#9773)

Artifact path was incorrectly set to use the artifact location instead of the filename.

Fixes aws#9767

---

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[codepipeline-actions] Service Catalog Integration sends improper format for file path
3 participants